Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261655: [PPC64] Build broken after JDK-8260941 #2548

Closed

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Feb 12, 2021

We have to add back CardTable* ct = ctbs->card_table(); after it was removed with JDK-8260941.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2548/head:pull/2548
$ git checkout pull/2548

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Feb 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Looks good and trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261655: [PPC64] Build broken after JDK-8260941

Reviewed-by: shade, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b670efd: 8261072: AArch64: Fix MacroAssembler::get_thread convention
  • 59b8d59: 8261481: Cannot read Kerberos settings in dynamic store on macOS Big Sur
  • 9f81ca8: 8261230: GC tracing of page sizes are wrong in a few places

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 12, 2021
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Feb 12, 2021

Thanks for the reviews!
/integrate

Loading

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@TheRealMDoerr Since your change was applied there have been 4 commits pushed to the master branch:

  • c0e805a: 8261654: Missing license header in Signatures.java
  • b670efd: 8261072: AArch64: Fix MacroAssembler::get_thread convention
  • 59b8d59: 8261481: Cannot read Kerberos settings in dynamic store on macOS Big Sur
  • 9f81ca8: 8261230: GC tracing of page sizes are wrong in a few places

Your commit was automatically rebased without conflicts.

Pushed as commit 6475d47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@TheRealMDoerr TheRealMDoerr deleted the 8261655_ppc64_build branch Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants