Skip to content

8357619: [JVMCI] Revisit phantom_ref parameter in JVMCINMethodData::get_nmethod_mirror #25488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8357619: [JVMCI] Revisit phantom_ref parameter in JVMCINMethodData::get_nmethod_mirror #25488

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dcb1c7
remove phantom_ref arg from JVMCINMethodData::get_nmethod_mirror
dougxc May 28, 2025
7456988
still rely on get_nmethod_mirror in invalidate_nmethod_mirror
dougxc Jun 2, 2025
e02be82
fixed typo
dougxc Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/hotspot/share/jvmci/jvmciRuntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,10 @@ void JVMCINMethodData::set_nmethod_mirror(nmethod* nm, oop new_mirror) {
}

void JVMCINMethodData::invalidate_nmethod_mirror(nmethod* nm) {
if (_nmethod_mirror_index == -1) {
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

}
oop nmethod_mirror = get_nmethod_mirror(nm);
if (nmethod_mirror == nullptr) {
return;
}

// Update the values in the mirror if it still refers to nm.
// We cannot use JVMCIObject to wrap the mirror as this is called
Expand Down