Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open #255

Closed
wants to merge 1 commit into from

Conversation

@skodanda
Copy link
Contributor

@skodanda skodanda commented Sep 18, 2020

Hello All,

Could you please review a TEST_BUG fix for the JDK 16?

Bug: https://bugs.openjdk.java.net/browse/JDK-8248352

Problem description: The test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially leave the frame open if it fails. If it were not for the frame, the test could be headless. So probably, we can remove the call to showText() from the test and make it headless..

Fix: An argument is added to the test. If "-show" is passed, the test will show UI for visual inspection.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/255/head:pull/255
$ git checkout pull/255

@bridgekeeper bridgekeeper bot added the oca label Sep 18, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2020

Hi @skodanda, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user skodanda" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@skodanda The following label will be automatically applied to this pull request: 2d.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the 2d label Sep 18, 2020
@skodanda skodanda changed the title <AWT Dev> RFR [16] 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open Sep 18, 2020
@skodanda
Copy link
Contributor Author

@skodanda skodanda commented Sep 18, 2020

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2020

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

prrace
prrace approved these changes Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@skodanda This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

Reviewed-by: prr, serb, aivanov
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 39 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ae20dd6b9becb3fe846da859504d0a82c00677d1.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2020

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 22, 2020

Since you remove the @headful keyword, did you check that the test works fine via mach5? It will now select a completely different set of test systems.

@skodanda
Copy link
Contributor Author

@skodanda skodanda commented Sep 22, 2020

mrserb
mrserb approved these changes Sep 22, 2020
@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 22, 2020

/reviewer credit aivanov

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@aivanov-jdk Only the author (@skodanda) is allowed to issue the reviewer command.

@skodanda
Copy link
Contributor Author

@skodanda skodanda commented Sep 22, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@skodanda
Your change (at version 53c1f5f) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 22, 2020

/sponsor

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated and removed sponsor labels Sep 22, 2020
@openjdk openjdk bot removed the ready label Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@aivanov-jdk @skodanda Since your change was applied there have been 39 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit aa38624.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants