8259535: ECDSA SignatureValue do not always have the specified length

[wangweij]

The code change fixes the ECDSA XML signature length issue. It should only happen when there is no P1363 ECDSA support, which is not true when SunEC is used.

If a PrivateKey is not of ECPrivateKey type then the bug will still show up. Technically, we can drill into the OID/parameter of the ASN.1 encoding and do further evaluation, but I think this is not worth doing. Please advise me if you think differently.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259535: ECDSA SignatureValue do not always have the specified length

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2550/head:pull/2550
$ git checkout pull/2550

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b166475)

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259535: ECDSA SignatureValue do not always have the specified length

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 311 new commits pushed to the master branch:

• 240f2a1: 8260366: ExtendedSocketOptions can deadlock in some circumstances
• de3f519: 8258897: wrong translation of capturing local classes inside nested lambdas
• d7efb4c: 8262199: issue in jli args.c
• 7603278: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
• 0a4e710: 8261954: Dependencies: Improve iteration over class hierarchy under context class
• 722142e: 8261520: JDK-8261302 breaks runtime/NMT/CheckForProperDetailStackTrace.java
• bcca100: 4710675: JTextArea.setComponentOrientation does not work with correct timing
• fce5765: 8262433: doclint: reference error in module jdk.incubator.foreign
• 059ede0: 8262428: doclint warnings in java.xml module
• 8256517: 8262421: doclint warnings in jdk.compiler module
• ... and 301 more: https://git.openjdk.java.net/jdk/compare/f025bc1d5d81532a3bdb87665537de4aaf15b7ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

@wangweij Since your change was applied there have been 319 commits pushed to the master branch:

• 2515c42: 8262332: serviceability/sa/ClhsdbJhisto.java fails with Test ERROR java.lang.RuntimeException: 'ParselTongue' missing from stdout/stderr
• 07061fc: 8256417: Exclude TestJFRWithJMX test from running with PodMan
• c9e9189: 8262074: Consolidate the default value of MetaspaceSize
• 05c11bc: 8262426: Change TRAPS to Thread* for find_constrained_instance_or_array_klass()
• d06d6f5: 8262402: Make CATCH macro assert not fatal
• 47a0842: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware
• 3088e1e: 8262430: doclint warnings in java.base module
• 67b9e5a: 8262420: typo: @implnote in java.desktop module
• 240f2a1: 8260366: ExtendedSocketOptions can deadlock in some circumstances
• de3f519: 8258897: wrong translation of capturing local classes inside nested lambdas
• ... and 309 more: https://git.openjdk.java.net/jdk/compare/f025bc1d5d81532a3bdb87665537de4aaf15b7ea...master

Your commit was automatically rebased without conflicts.

Pushed as commit a4c2496.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.