Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261659: JDK-8261027 causes a Tier1 validate-source failure #2551

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 12, 2021

A trivial fix to make Tier1 'validate-source' happy again.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261659: JDK-8261027 causes a Tier1 validate-source failure

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2551/head:pull/2551
$ git checkout pull/2551

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-compiler
/label add hotspot-runtime

@theRealAph - Just a heads up that I had to tweak one of your files (copyright header only).

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review February 12, 2021 16:05
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@dcubed-ojdk The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@dcubed-ojdk The hotspot-runtime label was already applied.

@mlbridge
Copy link

mlbridge bot commented Feb 12, 2021

Webrevs

Copy link
Member

@iignatev iignatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261659: JDK-8261027 causes a Tier1 validate-source failure

Reviewed-by: iignatyev, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 350303d: 8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion
  • 6475d47: 8261655: [PPC64] Build broken after JDK-8260941

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 12, 2021
@dcubed-ojdk
Copy link
Member Author

@iignatev and @bplb - Thanks for the fast reviews!

/integrate

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@dcubed-ojdk Since your change was applied there have been 3 commits pushed to the master branch:

  • 3aa1b4c: 8261623: reference to javac internals in Extern class
  • 350303d: 8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion
  • 6475d47: 8261655: [PPC64] Build broken after JDK-8260941

Your commit was automatically rebased without conflicts.

Pushed as commit 33fcd32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8261659 branch February 12, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants