8358057: Update validation of ICC_Profile header data

[mrserb]

The next PR introduces several new methods to the ICC_Profile class:

• getProfileClass(byte[])
• getColorSpaceType(byte[])
• getPCSType(byte[])
• checkRenderingIntent(byte[])

These new methods extract data directly from the provided byte array rather than relying on the profile instance. The first three methods essentially duplicate the existing ones (getProfileClass(), getColorSpaceType(), getPCSType()).

It is possible to update implementation:

• The existing methods getColorSpaceType() and getPCSType() could delegate to the new getColorSpaceType(byte[]) and getPCSType(byte[]) methods.
• The checkRenderingIntent(byte[]) method could be updated to report the actual invalid intent value when an error occurs

Tests:

• Old ValidateICCHeaderData test is update to verify the new output of the checkRenderingIntent
• New RenderingIntentStressTest test is added to check the next part of the icc_spec:

          * ICC spec: only the least-significant 16 bits encode the rendering
          * intent. The most significant 16 bits must be zero and can be ignored.
          * See https://www.color.org/ICC1v42_2006-05.pdf, section 7.2.15.

@honkar-jdk please take a look.

Note: There is currently an inconsistency in the usage of getData(icSigHead) vs getData(cmmProfile(), icSigHead) throughout the codebase. I plan to address this separately.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358057: Update validation of ICC_Profile header data (Bug - P4)

Reviewers

• Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25519/head:pull/25519
$ git checkout pull/25519

Update a local copy of the PR:
$ git checkout pull/25519
$ git pull https://git.openjdk.org/jdk.git pull/25519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25519

View PR using the GUI difftool:
$ git pr show -t 25519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25519.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358057: Update validation of ICC_Profile header data

Reviewed-by: honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

• 0418b32: 8357696: Enhance code consistency: java.desktop/unix
• 5243f38: 8357924: Remove runtime/ErrorHandling/CreateCoredumpOnCrash.java from problem list for macosx-x64
• 1373ceb: 8356698: JFR: @contextual
• ... and 81 more: https://git.openjdk.org/jdk/compare/2ec6ab347a18f454e33a3a281daf1d50a1fd5e27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (55d0fe2e)
• 02: Full - Incremental (43b88ff3)
• 01: Full - Incremental (cc41d6d4)
• 00: Full (fc6360d3)

[honkar-jdk]

Initial testing looks good.
I have added minor inline comments.

[honkar-jdk]

LGTM
CI Testing looks good.

[mrserb]

/integrate

[openjdk]

Going to push as commit 8939acc.
Since your change was applied there have been 152 commits pushed to the master branch:

• fd0ab04: 8358330: AsmRemarks and DbgStrings clear() method may not get called before their destructor
• 8a79ac8: 8358449: Locale.getISOCountries does not specify the returned set is unmodifiable
• ef47635: 8358015: Fix SequencedMap sequenced view method specifications
• ... and 149 more: https://git.openjdk.org/jdk/compare/2ec6ab347a18f454e33a3a281daf1d50a1fd5e27...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 8939acc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.