8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114

[larry-cable]

JDK-8358077:sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114

modified the code to place the Files::lines in a try-with-resources block in order to autoclose the Stream and underlying file resources immediately.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114 (Bug - P4)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• SendaoYan (@sendaoYan - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25529/head:pull/25529
$ git checkout pull/25529

Update a local copy of the PR:
$ git checkout pull/25529
$ git pull https://git.openjdk.org/jdk.git pull/25529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25529

View PR using the GUI difftool:
$ git pr show -t 25529

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25529.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back larry-cable! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@larry-cable This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114

Reviewed-by: kevinw, sspitsyn, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

• d7e58ac: 8351635: C2 ROR/ROL: assert failed: Long constant expected
• 5786200: 8354450: A File should be invalid if an element of its name sequence ends with a space
• 04c1546: 8358095: Cleanup tests with explicit locale provider set to only CLDR
• ... and 99 more: https://git.openjdk.org/jdk/compare/e509997fe87a09513b8f79d303cc69392d2cb7b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinjwalls, @sspitsyn, @sendaoYan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@larry-cable The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c30a4b31)

[kevinjwalls]

Looks good.

[sspitsyn]

Looks good.

[larry-cable]

/integrate

[openjdk]

@larry-cable
Your change (at version c30a4b3) is now ready to be sponsored by a Committer.

[kevinjwalls]

/sponsor

[openjdk]

Going to push as commit 44d62c8.
Since your change was applied there have been 102 commits pushed to the master branch:

• d7e58ac: 8351635: C2 ROR/ROL: assert failed: Long constant expected
• 5786200: 8354450: A File should be invalid if an element of its name sequence ends with a space
• 04c1546: 8358095: Cleanup tests with explicit locale provider set to only CLDR
• ... and 99 more: https://git.openjdk.org/jdk/compare/e509997fe87a09513b8f79d303cc69392d2cb7b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls @larry-cable Pushed as commit 44d62c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.