8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE

[ascarpino]

I need a code review to throw InvalidKeySpecException when null is passed with generatePublic() and generatePrivate(). This change takes the opportunity to modernize the KeyFactory code by using switch syntax for instanceof checking, as well as, keeping the previous design of the implementation method handling the null case. There are existing JCK test cover this case, so no regression test is added.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE (Bug - P3)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25533/head:pull/25533
$ git checkout pull/25533

Update a local copy of the PR:
$ git checkout pull/25533
$ git pull https://git.openjdk.org/jdk.git pull/25533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25533

View PR using the GUI difftool:
$ git pr show -t 25533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25533.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 94039e2: 8353230: Emoji rendering regression after JDK-8208377
• b7ca672: 8357047: [ubsan] AdapterFingerPrint::AdapterFingerPrint runtime error: index 3 out of bounds
• 82807d4: 8357184: Test vmTestbase/nsk/jdi/ExceptionEvent/itself/exevent008/TestDescription.java fails with unreported exception
• ... and 22 more: https://git.openjdk.org/jdk/compare/e306367813db7c8a3ecac5e46740600b7ab04f9d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@ascarpino The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (78653485)
• 00: Full (c5b9a941)

[ascarpino]

/integrate

[openjdk]

Going to push as commit c9d6e01.
Since your change was applied there have been 25 commits pushed to the master branch:

• 94039e2: 8353230: Emoji rendering regression after JDK-8208377
• b7ca672: 8357047: [ubsan] AdapterFingerPrint::AdapterFingerPrint runtime error: index 3 out of bounds
• 82807d4: 8357184: Test vmTestbase/nsk/jdi/ExceptionEvent/itself/exevent008/TestDescription.java fails with unreported exception
• ... and 22 more: https://git.openjdk.org/jdk/compare/e306367813db7c8a3ecac5e46740600b7ab04f9d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@ascarpino Pushed as commit c9d6e01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.