Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented May 30, 2025

Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent, add the respective keyword.
The test fails sometimes, see e.g. JDK-8338439 .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358136: Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25540/head:pull/25540
$ git checkout pull/25540

Update a local copy of the PR:
$ git checkout pull/25540
$ git pull https://git.openjdk.org/jdk.git pull/25540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25540

View PR using the GUI difftool:
$ git pr show -t 25540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25540.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358136: Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent

Reviewed-by: jpai, nbenalla, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8358136: Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent 8358136: Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent May 30, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label May 30, 2025
@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK and trivial to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2025
Copy link
Member

@nizarbenalla nizarbenalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change makes sense.

@MBaesken
Copy link
Member Author

MBaesken commented Jun 1, 2025

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Jun 1, 2025

Going to push as commit c1b5f62.
Since your change was applied there have been 33 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 1, 2025
@openjdk openjdk bot closed this Jun 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 1, 2025
@openjdk
Copy link

openjdk bot commented Jun 1, 2025

@MBaesken Pushed as commit c1b5f62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants