8357821: Revert incorrectly named JavaLangAccess::unchecked* methods

[vy]

Reverts certain JDK-8353197 (which implements JavaDoc improvement and precautionary naming for certain unsafe methods in jdk.internal.access.JavaLangAccess) changes that are found to be incorrect. See the JBS issue for details on the followed evaluation process.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357821: Revert incorrectly named JavaLangAccess::unchecked* methods (Enhancement - P4)

Reviewers

• Per Minborg (@minborg - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25545/head:pull/25545
$ git checkout pull/25545

Update a local copy of the PR:
$ git checkout pull/25545
$ git pull https://git.openjdk.org/jdk.git pull/25545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25545

View PR using the GUI difftool:
$ git pr show -t 25545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25545.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357821: Revert incorrectly named JavaLangAccess::unchecked* methods

Reviewed-by: pminborg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

• af87035: 8355746: Start of release updates for JDK 26
• c59e44a: 8357914: TestEmptyBootstrapMethodsAttr.java fails when run with TEST_THREAD_FACTORY=Virtual
• 23f1d4f: 8337666: AArch64: SHA3 GPR intrinsic
• ... and 152 more: https://git.openjdk.org/jdk/compare/acd64ba24afd508689803adaa6714a784946979c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vy The following labels will be automatically applied to this pull request:

• core-libs
• nio
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1e135598)
• 00: Full (bbf42347)

[wangweij]

/label remove security

[openjdk]

@wangweij
The security label was successfully removed.

[minborg]

The changes look good to me. I wonder if we should add that implementations of the affected method shall do bounds checking to reduce the likelihood of a new/updated native implementation miss that?

[vy]

I wonder if we should add that implementations of the affected method shall do bounds checking to reduce the likelihood of a new/updated native implementation miss that?

@minborg, would you mind elaborating on this a bit, please? Do you imply adding an @implSpec to the touched JavaLangAccess methods?

[minborg]

I wonder if we should add that implementations of the affected method shall do bounds checking to reduce the likelihood of a new/updated native implementation miss that?

@minborg, would you mind elaborating on this a bit, please? Do you imply adding an @implSpec to the touched JavaLangAccess methods?

Yes, I think that would be a good thing to do.

[vy]

@minborg, added @implSpec in 1e13559.

[minborg]

LGTM. Thank you for these updates!

[vy]

/integrate

[openjdk]

Going to push as commit e918a59.
Since your change was applied there have been 162 commits pushed to the master branch:

• 28acca6: 8358653: [s390] Clean up comments regarding frame manager
• 029e3bf: 8349914: ZipFile::entries and ZipFile::getInputStream not consistent with each other when there are duplicate entries
• 78158f3: 8358099: PEM spec updates
• ... and 159 more: https://git.openjdk.org/jdk/compare/acd64ba24afd508689803adaa6714a784946979c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vy Pushed as commit e918a59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.