8261672: Reduce inclusion of classLoaderData.hpp

[iklam]

classLoaderData.hpp is included by about 700 out of 1000 .o files in HotSpot. Most of these are transitively included through klass.hpp, typeArrayKlass.hpp and instanceKlass.hpp.

These headers can be refactored by moving inline functions that depend on ClassLoaderData to xxx.inline.hpp. This reduces the .o files that include classLoaderData.hpp to about 260.

(I also removed a bunch of unnecessary inclusion of classLoader.hpp from a few C files).

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261672: Reduce inclusion of classLoaderData.hpp

Reviewers

• Lois Foltan (@lfoltan - Reviewer) ⚠️ Review applies to 96f3b68
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 96f3b68

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2555/head:pull/2555
$ git checkout pull/2555

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[iklam]

/label remove serviceability

[openjdk]

@iklam
The serviceability label was successfully removed.

[mlbridge]

Webrevs

• 01: Full - Incremental (ea39695)
• 00: Full (96f3b68)

[lfoltan]

LGTM.
Lois

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261672: Reduce inclusion of classLoaderData.hpp

Reviewed-by: lfoltan, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Looks good. I think adding compiledICHolder.inline.hpp is worth doing because performance matters to its caller in compiledMethod.cpp.

[iklam]

Thanks @coleenp and @lfoltan for the review.
/integrate

[openjdk]

@iklam Pushed as commit 235da6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.