Skip to content

Conversation

@matias9927
Copy link
Contributor

@matias9927 matias9927 commented May 30, 2025

FieldInfo::_index is not initialized in either of the FieldInfo constructors so this patch adds initialization to both constructors. Verified with tier 1-5 tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357576: FieldInfo::_index is not initialized by the constructor (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25554/head:pull/25554
$ git checkout pull/25554

Update a local copy of the PR:
$ git checkout pull/25554
$ git pull https://git.openjdk.org/jdk.git pull/25554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25554

View PR using the GUI difftool:
$ git pr show -t 25554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25554.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357576: FieldInfo::_index is not initialized by the constructor

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 30, 2025
@matias9927 matias9927 marked this pull request as ready for review May 30, 2025 20:33
@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2025
@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

Copy link
Member

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the copyright year to 2025

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial, but does need copyright year update. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jun 2, 2025
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2025
@matias9927
Copy link
Contributor Author

Thank you @sendaoYan @coleenp and @dholmes-ora for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

Going to push as commit 1b6ae20.
Since your change was applied there have been 47 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 2, 2025
@openjdk openjdk bot closed this Jun 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2025
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@matias9927 Pushed as commit 1b6ae20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants