-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8357576: FieldInfo::_index is not initialized by the constructor #25554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into |
|
@matias9927 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 45 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@matias9927 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
sendaoYan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the copyright year to 2025
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial, but does need copyright year update. Thanks.
coleenp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thank you @sendaoYan @coleenp and @dholmes-ora for the reviews! |
|
Going to push as commit 1b6ae20.
Your commit was automatically rebased without conflicts. |
|
@matias9927 Pushed as commit 1b6ae20. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
FieldInfo::_index is not initialized in either of the FieldInfo constructors so this patch adds initialization to both constructors. Verified with tier 1-5 tests
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25554/head:pull/25554$ git checkout pull/25554Update a local copy of the PR:
$ git checkout pull/25554$ git pull https://git.openjdk.org/jdk.git pull/25554/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25554View PR using the GUI difftool:
$ git pr show -t 25554Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25554.diff
Using Webrev
Link to Webrev Comment