-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8357924: Remove runtime/ErrorHandling/CreateCoredumpOnCrash.java from problem list for macosx-x64 #25556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
|
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label hotspot-runtime |
|
@plummercj |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
|
Thank you for the reviews David and Sandao! /integrate |
|
Going to push as commit 5243f38.
Your commit was automatically rebased without conflicts. |
|
@plummercj Pushed as commit 5243f38. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove CreateCoredumpOnCrash.java from problem list. JDK-8267433 was closed because it only reproduced with OSX 11, which is no longer supported. SA core file tests were removed from the problem list, but this test was missed.
Test by running 100 times on macosx-x64 and macosx-x64-debug. Also ran hotspot_tier2_runtime 5 tmes.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25556/head:pull/25556$ git checkout pull/25556Update a local copy of the PR:
$ git checkout pull/25556$ git pull https://git.openjdk.org/jdk.git pull/25556/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25556View PR using the GUI difftool:
$ git pr show -t 25556Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25556.diff
Using Webrev
Link to Webrev Comment