8358178: Some nsk/jdi tests should be run with includevirtualthreads=y even though they pass without

[plummercj]

Use -includevirtualthreads with tests use vm.allThreads() and pass with or without it. Using -includevirtualthreads gives us better virtual thread test coverage. Otherwise only the returned platform threads get tested.

Tested by running affected tests locally.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358178: Some nsk/jdi tests should be run with includevirtualthreads=y even though they pass without (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25557/head:pull/25557
$ git checkout pull/25557

Update a local copy of the PR:
$ git checkout pull/25557
$ git pull https://git.openjdk.org/jdk.git pull/25557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25557

View PR using the GUI difftool:
$ git pr show -t 25557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25557.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358178: Some nsk/jdi tests should be run with includevirtualthreads=y even though they pass without

Reviewed-by: sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• 5786200: 8354450: A File should be invalid if an element of its name sequence ends with a space
• 04c1546: 8358095: Cleanup tests with explicit locale provider set to only CLDR
• 16e120b: 8357910: LoaderConstraintsTest.java fails when run with TEST_THREAD_FACTORY=Virtual
• ... and 72 more: https://git.openjdk.org/jdk/compare/14e41ab055955ffd7cf9e8129cc3269b4e3807b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c1f3cb1c)

[sspitsyn]

Looks good.

[plummercj]

Thank you for the reviews Serguei and Leonid!

/integrate

[openjdk]

Going to push as commit c382da5.
Since your change was applied there have been 77 commits pushed to the master branch:

• 44d62c8: 8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114
• d7e58ac: 8351635: C2 ROR/ROL: assert failed: Long constant expected
• 5786200: 8354450: A File should be invalid if an element of its name sequence ends with a space
• ... and 74 more: https://git.openjdk.org/jdk/compare/14e41ab055955ffd7cf9e8129cc3269b4e3807b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit c382da5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.