Skip to content

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 1, 2025

This test is causing a lot of failures in itself and other tests running at the same time due to excessive memory consumption.

Thank you.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358259: ProblemList compiler/startup/StartupOutput.java on Windows (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25572/head:pull/25572
$ git checkout pull/25572

Update a local copy of the PR:
$ git checkout pull/25572
$ git pull https://git.openjdk.org/jdk.git pull/25572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25572

View PR using the GUI difftool:
$ git pr show -t 25572

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25572.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2025

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 1, 2025

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358259: ProblemList compiler/startup/StartupOutput.java on Windows

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2025
@openjdk
Copy link

openjdk bot commented Jun 1, 2025

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2025
@dholmes-ora
Copy link
Member Author

Thanks @jddarcy

/integrate

@openjdk
Copy link

openjdk bot commented Jun 1, 2025

Going to push as commit 3193a28.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 1, 2025
@openjdk openjdk bot closed this Jun 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 1, 2025
@openjdk
Copy link

openjdk bot commented Jun 1, 2025

@dholmes-ora Pushed as commit 3193a28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8358259-pl branch June 1, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants