8345347: Test runtime/cds/TestDefaultArchiveLoading.java should accept VM flags or be marked as flagless

[matias9927]

Currently this test uses ProcessTools.createLimitedTestJavaProcessBuilder() to ignore vm flags, so this patch changes the method to ProcessTools.createTestJavaProcessBuilder() to allow for more extensive training. Because ZGC is incompatible with heap dumping, is is disabled on this test. Verified locally and through tiered testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345347: Test runtime/cds/TestDefaultArchiveLoading.java should accept VM flags or be marked as flagless (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer) Review applies to 9ef0863f
• Calvin Cheung (@calvinccheung - Reviewer) Review applies to 9ef0863f
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25591/head:pull/25591
$ git checkout pull/25591

Update a local copy of the PR:
$ git checkout pull/25591
$ git pull https://git.openjdk.org/jdk.git pull/25591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25591

View PR using the GUI difftool:
$ git pr show -t 25591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25591.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345347: Test runtime/cds/TestDefaultArchiveLoading.java should accept VM flags or be marked as flagless

Reviewed-by: lmesnik, stefank, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

• 5786200: 8354450: A File should be invalid if an element of its name sequence ends with a space
• 04c1546: 8358095: Cleanup tests with explicit locale provider set to only CLDR
• 16e120b: 8357910: LoaderConstraintsTest.java fails when run with TEST_THREAD_FACTORY=Virtual
• ... and 83 more: https://git.openjdk.org/jdk/compare/ae3d96a4ec87262bc2f01d87fe91daa5d0d3966f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (12c5a5df)
• 01: Full - Incremental (9ef0863f)
• 00: Full (3e41fdef)

[stefank]

We already have this property that is used for some tests:

@requires vm.cds.write.archived.java.heap

Should this be used here instead of explicitly excluding ZGC?

This property boils down to:

// If an incompatible VM options is found, return a text message that explains why
static const char* check_options_incompatible_with_dumping_heap() {
#if INCLUDE_CDS_JAVA_HEAP
  if (!UseCompressedClassPointers) {
    return "UseCompressedClassPointers must be true";
  }

  // Almost all GCs support heap region dump, except ZGC (so far).
  if (UseZGC) {
    return "ZGC is not supported";
  }

  return nullptr;
#else
  return "JVM not configured for writing Java heap objects";
#endif
}

[matias9927]

We already have this property that is used for some tests:

@requires vm.cds.write.archived.java.heap

Should this be used here instead of explicitly excluding ZGC?

This property boils down to:

// If an incompatible VM options is found, return a text message that explains why
static const char* check_options_incompatible_with_dumping_heap() {
#if INCLUDE_CDS_JAVA_HEAP
  if (!UseCompressedClassPointers) {
    return "UseCompressedClassPointers must be true";
  }

  // Almost all GCs support heap region dump, except ZGC (so far).
  if (UseZGC) {
    return "ZGC is not supported";
  }

  return nullptr;
#else
  return "JVM not configured for writing Java heap objects";
#endif
}

I forgot this existed, thanks for pointing it out!

[calvinccheung]

LGTM.

[stefank]

Looks good!

[sendaoYan]

Should we update the copyright year from 2024 to 2024, 2025

[matias9927]

Do I need to update the Red Hat copyright as well?

[sendaoYan]

Maybe not need I think

[matias9927]

Thank you for the reviews @sendaoYan, @lmesnik, @calvinccheung, and @stefank!
/integrate

[openjdk]

Going to push as commit a2723d9.
Since your change was applied there have been 120 commits pushed to the master branch:

• ae1892f: 8358003: KlassTrainingData initializer reads garbage holder
• 0352477: 8357660: [JVMCI] Add support for retrieving all BootstrapMethodInvocations directly from ConstantPool
• a653ff4: 8358536: jdk/jfr/api/consumer/TestRecordingFileWrite.java times out
• ... and 117 more: https://git.openjdk.org/jdk/compare/ae3d96a4ec87262bc2f01d87fe91daa5d0d3966f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@matias9927 Pushed as commit a2723d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.