Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable #256

Closed
wants to merge 1 commit into from
Closed

8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable #256

wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Sep 18, 2020

This test is being marked intermittent, although at the same time I am trying to make it less likely to fail.
However since we have a known issue around NIO mmap'd files not being directly unmappable, the
deletes the font system make may be stymied on Windows. So marking it intermittent is probably for the best
One other thing is that I changed it so that the tmp files created are now of different sizes so we can now
tell which createFont() call resulted in the font that can't be deleted. If it is always the Type 1 fonts then
that will be good evidence it is mmap that is the problem.
We likely need to stop using mmap for this reason.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/256/head:pull/256
$ git checkout pull/256

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@prrace The following label will be automatically applied to this pull request: 2d.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

mrserb
mrserb approved these changes Sep 19, 2020
@openjdk
Copy link

openjdk bot commented Sep 19, 2020

@prrace This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable

Reviewed-by: serb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 57 commits pushed to the master branch:

  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • f37c34d: 8253270: Limit fastdebug inlining in G1 evacuation
  • 8904420: 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc
  • 52c28b8: 8253239: Disable VS warning C4307
  • 05572e8: 8253350: Remove unimplemented SharedRuntime::clean_*_entry
  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/fc36328d4f35627427f7352f5db6feb0e1e469f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1438ce097f4b327570504066a3f999163802a14f.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2020
@prrace
Copy link
Contributor Author

prrace commented Sep 19, 2020

/integrate

@prrace prrace closed this Sep 19, 2020
@prrace prrace reopened this Sep 19, 2020
@prrace
Copy link
Contributor Author

prrace commented Sep 19, 2020

/integrate

@openjdk openjdk bot closed this Sep 19, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2020
@openjdk
Copy link

openjdk bot commented Sep 19, 2020

@prrace Since your change was applied there have been 57 commits pushed to the master branch:

  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • f37c34d: 8253270: Limit fastdebug inlining in G1 evacuation
  • 8904420: 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc
  • 52c28b8: 8253239: Disable VS warning C4307
  • 05572e8: 8253350: Remove unimplemented SharedRuntime::clean_*_entry
  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/fc36328d4f35627427f7352f5db6feb0e1e469f0...master

Your commit was automatically rebased without conflicts.

Pushed as commit d27835b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the deletefont branch Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants