8358520: Improve lazy computation in BreakIteratorResourceBundle and related classes

[minborg]

This PR proposes to simplify lazy computation related to resource bundles. Previously, some objects were computed lazily using a double-checked locking algorithm. StableValues offers a more robust and succinct solution.

This PR passes tier1, tier2, and tier3 on multiple platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358520: Improve lazy computation in BreakIteratorResourceBundle and related classes (Enhancement - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Justin Lu (@justin-curtis-lu - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25630/head:pull/25630
$ git checkout pull/25630

Update a local copy of the PR:
$ git checkout pull/25630
$ git pull https://git.openjdk.org/jdk.git pull/25630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25630

View PR using the GUI difftool:
$ git pr show -t 25630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25630.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358520: Improve lazy computation in BreakIteratorResourceBundle and related classes

Reviewed-by: naoto, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• 78158f3: 8358099: PEM spec updates
• c793de9: 8350212: Track source end positions of declarations that support @SuppressWarnings
• 15178aa: 8357688: Remove unnecessary List.get before remove in PopupFactory
• ... and 63 more: https://git.openjdk.org/jdk/compare/406f1bc5b94408778063b885cdac807fd1501e44...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@minborg The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (de4fea12)

[naotoj]

Looks good and clean. Thanks for the refactoring, Per!

[justin-curtis-lu]

Should we consider converting lookup in ParallelListResourceBundle.java to be a stable supplier of the CHM as well? Then separating the creation of the map from the insertion of parallel data.

[naotoj]

I am thinking about removing javatime supplementary logic altogether, including ParallelListResourceBundle. Might be good to wait for it

[minborg]

/integrate

[openjdk]

Going to push as commit 52338c9.
Since your change was applied there have been 81 commits pushed to the master branch:

• 91f1260: 8345067: C2: enable implicit null checks for ZGC reads
• 6c616c7: 8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations
• e94ad55: 8342639: Global operator new in adlc has wrong exception spec
• ... and 78 more: https://git.openjdk.org/jdk/compare/406f1bc5b94408778063b885cdac807fd1501e44...master

Your commit was automatically rebased without conflicts.

[openjdk]

@minborg Pushed as commit 52338c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.