Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261607: SA attach is exceeding JNI Local Refs capacity #2568

Closed
wants to merge 3 commits into from

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Feb 15, 2021

Delete some localrefs to avoid -Xcheck:jni warnings. See CR for details.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261607: SA attach is exceeding JNI Local Refs capacity

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2568/head:pull/2568
$ git checkout pull/2568

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 15, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2021

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 15, 2021

Webrevs

// Make sure no -Xcheck:jni failures. WARNING: JNI local refs
oa.shouldNotMatch("^WARNING: JNI local refs:.*$");
oa.shouldNotMatch("^WARNING in native method:.*$");
Comment on lines 147 to 149

This comment has been minimized.

@jerboaa

jerboaa Feb 15, 2021
Contributor

It's not clear to me why this matcher is being done without any tests using -Xcheck:jni. Is this intentional?

This comment has been minimized.

@plummercj

plummercj Feb 15, 2021
Author Contributor

Although no Clhsdb test is explicitly always runs with -Xcheck:jni, the option can be added to any test run. For example:

$ make test TEST=open/test/hotspot/jtreg/serviceability/sa/ TEST_VM_OPTS="-Xcheck:jni"

This matching is done to make sure there are no warnings when the test is run in this manner. The matching could be conditional on the test being run with -Xcheck:jni, but I don't really see to point in cluttering up the logic with such a check since the warnings should never appear, whether or not you are using -Xcheck:jni.

This comment has been minimized.

@jerboaa

jerboaa Feb 15, 2021
Contributor

OK, I thought so. Could you expand on the comment saying so, please? Suggestion: Make sure there are no -Xcheck:jni warnings as -Xcheck:jni might be set via TEST_VM_OPTS on test runs.

This comment has been minimized.

@plummercj

plummercj Feb 15, 2021
Author Contributor

Ok, the comment has been updated. Thanks!

Copy link
Contributor

@jerboaa jerboaa left a comment

Other than the comment suggestion this looks reasonable to me.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261607: SA attach is exceeding JNI Local Refs capacity

Reviewed-by: sgehwolf, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 3cbd16d: 8259668: Make SubTasksDone use-once
  • 219b115: 8261422: Adjust problematic String.format calls in jdk/internal/util/Preconditions.java outOfBoundsMessage
  • cdc874d: 8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0
  • e2d52ae: 8261413: Shenandoah: Disable class-unloading in I-U mode
  • 34ae7ae: 8261609: remove remnants of XML-driven builders
  • 6badd22: 8261351: Create implementation for NSAccessibilityRadioButton protocol
  • 849f4c0: 8260291: The case instruction is not visible in dark mode
  • 2e610f5: 8260687: Inherited font size is smaller than expected when using StyleSheet to add styles
  • 3882fda: 8260414: Remove unused set_single_threaded_mode() method in task executor
  • c6eedda: 8261500: Shenandoah: reconsider region live data memory ordering
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/235da6aa048a9c5b3a702bdd9ab54017f14f097b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 15, 2021
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Feb 16, 2021

/integrate

@openjdk openjdk bot closed this Feb 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@plummercj Since your change was applied there have been 21 commits pushed to the master branch:

  • 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
  • 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
  • 8ba390d: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • 16bd7d3: 8261336: IGV: enhance default filters
  • 3f8819c: 8261501: Shenandoah: reconsider heap statistics memory ordering
  • 3cbd16d: 8259668: Make SubTasksDone use-once
  • 219b115: 8261422: Adjust problematic String.format calls in jdk/internal/util/Preconditions.java outOfBoundsMessage
  • cdc874d: 8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0
  • e2d52ae: 8261413: Shenandoah: Disable class-unloading in I-U mode
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/235da6aa048a9c5b3a702bdd9ab54017f14f097b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 55d7bbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the plummercj:8261607-jnicheck branch Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants