8355298: Increase timeout for StressAsyncUL#25695
8355298: Increase timeout for StressAsyncUL#25695jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@jdksjolen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
shipilev
left a comment
There was a problem hiding this comment.
I think it is fine to switch to debug, if that indeed produces much fewer messages, while still testing the stalling mode.
|
@jdksjolen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@jdksjolen This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Hi,
Running async UL with stalling mode enabled is very slow if your buffer is very small. This turns out to become an issue on slow machines, where we run the risk of the test timing out.
The ticket's suggestion (and title) is to increase the timeout. I think that it'd be fine to reduce the logging level to 'debug' instead, thus reducing the time required to run the test.
Obviously, if we go with this solution then the ticket name and description must be adjusted.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25695/head:pull/25695$ git checkout pull/25695Update a local copy of the PR:
$ git checkout pull/25695$ git pull https://git.openjdk.org/jdk.git pull/25695/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25695View PR using the GUI difftool:
$ git pr show -t 25695Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25695.diff
Using Webrev
Link to Webrev Comment