Skip to content

8355298: Increase timeout for StressAsyncUL#25695

Closed
jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
jdksjolen:8355298-increase-stressasyncul-timeout
Closed

8355298: Increase timeout for StressAsyncUL#25695
jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
jdksjolen:8355298-increase-stressasyncul-timeout

Conversation

@jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Jun 9, 2025

Hi,

Running async UL with stalling mode enabled is very slow if your buffer is very small. This turns out to become an issue on slow machines, where we run the risk of the test timing out.

The ticket's suggestion (and title) is to increase the timeout. I think that it'd be fine to reduce the logging level to 'debug' instead, thus reducing the time required to run the test.

Obviously, if we go with this solution then the ticket name and description must be adjusted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355298: Increase timeout for StressAsyncUL (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25695/head:pull/25695
$ git checkout pull/25695

Update a local copy of the PR:
$ git checkout pull/25695
$ git pull https://git.openjdk.org/jdk.git pull/25695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25695

View PR using the GUI difftool:
$ git pr show -t 25695

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25695.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8355298 8355298: Increase timeout for StressAsyncUL Jun 9, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to switch to debug, if that indeed produces much fewer messages, while still testing the stalling mode.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

@jdksjolen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2025

@jdksjolen This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants