8351413: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport#25697
Conversation
…odelmbean/DescriptorSupport
|
/csr |
|
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
|
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 373 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request. @kevinjwalls please create a CSR request for issue JDK-8351413 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
@kevinjwalls The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
sspitsyn
left a comment
There was a problem hiding this comment.
This looks okay.
The CSR's "Compatibility Risk Description" should not be empty.
Also reviewed the RN and added a minor suggestion.
|
Thanks Daniel! Thanks Serguei, have addressed those points. |
|
/integrate |
|
Going to push as commit 13e0f99.
Your commit was automatically rebased without conflicts. |
|
@kevinjwalls Pushed as commit 13e0f99. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Removal of an obscure historical feature, following on from its deprecation for removal in:
8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal
Progress
Issues
Backport <hash>with the hash of the original commit. See Backports.Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25697/head:pull/25697$ git checkout pull/25697Update a local copy of the PR:
$ git checkout pull/25697$ git pull https://git.openjdk.org/jdk.git pull/25697/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25697View PR using the GUI difftool:
$ git pr show -t 25697Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25697.diff
Using Webrev
Link to Webrev Comment