Skip to content

8351413: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport#25697

Closed
kevinjwalls wants to merge 1 commit intoopenjdk:masterfrom
kevinjwalls:8351413_DescriptorSupport_XML_interchange
Closed

8351413: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport#25697
kevinjwalls wants to merge 1 commit intoopenjdk:masterfrom
kevinjwalls:8351413_DescriptorSupport_XML_interchange

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jun 9, 2025

Removal of an obscure historical feature, following on from its deprecation for removal in:

8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8359663 to be approved

Issues

  • JDK-8351413: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport (Enhancement - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
  • JDK-8359663: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25697/head:pull/25697
$ git checkout pull/25697

Update a local copy of the PR:
$ git checkout pull/25697
$ git pull https://git.openjdk.org/jdk.git pull/25697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25697

View PR using the GUI difftool:
$ git pr show -t 25697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25697.diff

Using Webrev

Link to Webrev Comment

@kevinjwalls
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351413: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport

Reviewed-by: dfuchs, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 373 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8351413 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jun 9, 2025
@kevinjwalls kevinjwalls marked this pull request as ready for review June 12, 2025 08:05
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2025

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable. Please get a Reviewer from serviceability too before integrating.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay.
The CSR's "Compatibility Risk Description" should not be empty.
Also reviewed the RN and added a minor suggestion.

@kevinjwalls
Copy link
Contributor Author

Thanks Daniel! Thanks Serguei, have addressed those points.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 9, 2025
@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

Going to push as commit 13e0f99.
Since your change was applied there have been 373 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2025
@openjdk openjdk bot closed this Jul 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@kevinjwalls Pushed as commit 13e0f99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants