-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8359126: [AIX] new test TestImplicitNullChecks.java fails #25728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8359126: [AIX] new test TestImplicitNullChecks.java fails #25728
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@robcasloz: Sorry that I had forgotten to check AIX. |
|
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Thanks for the review! |
|
Thanks! |
|
Going to push as commit abc76c6.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit abc76c6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Switch off the IR rule which expects no explicit null check for a load operation for AIX. I had to enhance the IR code.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25728/head:pull/25728$ git checkout pull/25728Update a local copy of the PR:
$ git checkout pull/25728$ git pull https://git.openjdk.org/jdk.git pull/25728/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25728View PR using the GUI difftool:
$ git pr show -t 25728Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25728.diff
Using Webrev
Link to Webrev Comment