8355556: JVM crash because archived method handle intrinsics are not restored

[iklam]

AOTLinkedClassBulkLoader::finish_loading_javabase_classes() can execute Java bytecodes (from <clinit>). If one of these bytecodes is an AOT-resolved invokedynamic, it may be dispatched using an archived method handle intrinsic. Therefore, we should call SystemDictionary::restore_archived_method_handle_intrinsics() first to make sure that the method handle intrinsics are ready to be used.

In the JDK mainline, we only execute a very limited set of Java methods which happens to not include any invokedynamic bytecodes. That's why this bug has not been found in the mainline.

However, in the Leyden repo, we have other optimizations, such as archived ProtectionDomains, which will cause invokedynamic bytecodes to be executed inside AOTLinkedClassBulkLoader::finish_loading_javabase_classes().

Since this is a potential issue even for the JDK mainline, we should fix it (and also backport to JDK 25).

Thanks to @iwanowww for providing the fix!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355556: JVM crash because archived method handle intrinsics are not restored (Bug - P3)

Reviewers

• Andrew Dinn (@adinn - Reviewer)
• Vladimir Ivanov (@iwanowww - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25766/head:pull/25766
$ git checkout pull/25766

Update a local copy of the PR:
$ git checkout pull/25766
$ git pull https://git.openjdk.org/jdk.git pull/25766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25766

View PR using the GUI difftool:
$ git pr show -t 25766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25766.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355556: JVM crash because archived method handle intrinsics are not restored

Reviewed-by: adinn, vlivanov, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 3a18872: 8359225: Remove unused test/jdk/javax/script/MyContext.java
• e7f63ba: 8359327: Incorrect AVX3Threshold results into code buffer overflows on APX targets
• a0fb35c: 8359272: Several vmTestbase/compact tests timed out on large memory machine
• ... and 33 more: https://git.openjdk.org/jdk/compare/e9216efefc12b04c372a0a7f47167c984be544b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (56f97d08)

[adinn]

Looks good.

[iwanowww]

Looks good.

[iklam]

Thanks @adinn @iwanowww @shipilev for the review
/integrate

[openjdk]

Going to push as commit 366650a.
Since your change was applied there have been 44 commits pushed to the master branch:

• 78b1360: 8359127: Amend java/nio/channels/DatagramChannel/PromiscuousIPv6.java to use @requires for OS platform selection
• 417f8ec: 8359224: G1: Incorrect size unit in logging of G1CollectedHeap::alloc_archive_region
• 57cabc6: 8359364: java/net/URL/EarlyOrDelayedParsing test fails intermittently
• ... and 41 more: https://git.openjdk.org/jdk/compare/e9216efefc12b04c372a0a7f47167c984be544b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 366650a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.