8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

[mychris]

Adds an explicit -Xms to one part of the test case, to not rely on ergonomics to detect the correct InitialHeapSize.

It looks like one part of the whole test case implicitly relied on the fact, that InitialHeapSize == MaxHeapSize. Since the MaxHeapSize is very small (32M), this is almost always true. But if the test device has less than 2G of memory, the ergonomics configure the InitialHeapSize to be smaller than the MaxHeapSize.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2577/head:pull/2577
$ git checkout pull/2577

[bridgekeeper]

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mychris The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3c8c401)

[openjdk]

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 8418285: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check
• a930870: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
• b955f85: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
• d195033: 8261842: Shenandoah: cleanup ShenandoahHeapRegionSet
• fc1d032: 8261125: Move VM_Operation to vmOperation.hpp
• d547e1a: 8261123: Augment discussion of equivalence classes in Object.equals and comparison methods
• 2677f6f: 8261675: ObjectValue::set_visited(bool) sets _visited false
• e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
• 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
• 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/3882fda83bebf4a8c8100fd59c37f04610491ce7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kstefanj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mychris]

Thanks for the review.
/integrate

[openjdk]

@mychris
Your change (at version 3c8c401) is now ready to be sponsored by a Committer.

[tschatzl]

/sponsor

[openjdk]

@tschatzl @mychris Since your change was applied there have been 25 commits pushed to the master branch:

• 05d5955: 8261522: [PPC64] AES intrinsics write beyond the destination array
• 03b586b: 8261750: Remove internal class sun.net.www.MimeLauncher
• 8418285: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check
• a930870: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
• b955f85: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
• d195033: 8261842: Shenandoah: cleanup ShenandoahHeapRegionSet
• fc1d032: 8261125: Move VM_Operation to vmOperation.hpp
• d547e1a: 8261123: Augment discussion of equivalence classes in Object.equals and comparison methods
• 2677f6f: 8261675: ObjectValue::set_visited(bool) sets _visited false
• e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/3882fda83bebf4a8c8100fd59c37f04610491ce7...master

Your commit was automatically rebased without conflicts.

Pushed as commit c7885eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.