8358738: AOT cache created without graal jit should not be used with graal jit

[vnkozlov]

We can't mix generation and usage of AOT cache when different JIT compilers are used (C2 vs Graal). Graal does different profiling settings and generate different code. We can only allow mix with Interpreter.

Record used compiler type in archive and check it when using archive.

Tested with tiers which use Graal.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358738: AOT cache created without graal jit should not be used with graal jit (Bug - P3)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25782/head:pull/25782
$ git checkout pull/25782

Update a local copy of the PR:
$ git checkout pull/25782
$ git pull https://git.openjdk.org/jdk.git pull/25782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25782

View PR using the GUI difftool:
$ git pr show -t 25782

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25782.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358738: AOT cache created without graal jit should not be used with graal jit

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 366650a: 8355556: JVM crash because archived method handle intrinsics are not restored
• 78b1360: 8359127: Amend java/nio/channels/DatagramChannel/PromiscuousIPv6.java to use @requires for OS platform selection
• 417f8ec: 8359224: G1: Incorrect size unit in logging of G1CollectedHeap::alloc_archive_region
• ... and 28 more: https://git.openjdk.org/jdk/compare/e18277b470a162b9668297e8e286c812c4b0b604...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (20c80da8)
• 00: Full (3a8c8e5b)

[iklam]

Looks good. Suggestions for code clean up and inline comments.

[vnkozlov]

Thank you, @iklam, for review. I addressed your comments.

[iklam]

LGTM

[calvinccheung]

Looks good. I have one question.

[vnkozlov]

Thank you @calvinccheung for review.

[vnkozlov]

/integrate

[openjdk]

Going to push as commit 12a0dd0.
Since your change was applied there have been 31 commits pushed to the master branch:

• 366650a: 8355556: JVM crash because archived method handle intrinsics are not restored
• 78b1360: 8359127: Amend java/nio/channels/DatagramChannel/PromiscuousIPv6.java to use @requires for OS platform selection
• 417f8ec: 8359224: G1: Incorrect size unit in logging of G1CollectedHeap::alloc_archive_region
• ... and 28 more: https://git.openjdk.org/jdk/compare/e18277b470a162b9668297e8e286c812c4b0b604...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov Pushed as commit 12a0dd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.