Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252199: Reimplement support of Type 1 fonts without MappedByteBuffer #258

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Sep 18, 2020

I changed it to read the file into a ByteBuffer to avoid the problem that we can't control when NIO free's the mmaped buffer. This is a problem for leaking tmp Type1 font files when using createFont and I thought maybe we could just change that case, but Type 1 fonts are getting very rare. Neither Mac nor Windows ship them and Mac at least does not support them at all, and current Linuxes seem to be almost all TTF and OTF fonts. Also T1 fonts are small, so any minimal peformance benefit is not worth it. There isn't a specific regression test.
I verified this on Ubuntu 20.04 which has at least a (very) few Type 1 fonts.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252199: Reimplement support of Type 1 fonts without MappedByteBuffer

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/258/head:pull/258
$ git checkout pull/258

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@prrace The following label will be automatically applied to this pull request: 2d.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Sep 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 18, 2020

Webrevs

mrserb
mrserb approved these changes Sep 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 19, 2020

@prrace This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252199: Reimplement support of Type 1 fonts without MappedByteBuffer

Reviewed-by: serb, jdv
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 9 commits pushed to the master branch:

  • 3d88d38: 8252070: Some platform-specific BLIT optimizations are not effective
  • 83b0537: 8253291: bug7072653.java still failed "Popup window height ... is wrong"
  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • f37c34d: 8253270: Limit fastdebug inlining in G1 evacuation

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 3d88d387c35aa52824a45e926d2ba84b6da6e60c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2020
@prrace
Copy link
Contributor Author

@prrace prrace commented Sep 20, 2020

/integrate

@openjdk openjdk bot closed this Sep 20, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2020

@prrace Since your change was applied there have been 9 commits pushed to the master branch:

  • 3d88d38: 8252070: Some platform-specific BLIT optimizations are not effective
  • 83b0537: 8253291: bug7072653.java still failed "Popup window height ... is wrong"
  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • f37c34d: 8253270: Limit fastdebug inlining in G1 evacuation

Your commit was automatically rebased without conflicts.

Pushed as commit cc7521c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the mmap branch Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants