-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252199: Reimplement support of Type 1 fonts without MappedByteBuffer #258
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
@prrace The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
@prrace This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 9 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prrace Since your change was applied there have been 9 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit cc7521c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I changed it to read the file into a ByteBuffer to avoid the problem that we can't control when NIO free's the mmaped buffer. This is a problem for leaking tmp Type1 font files when using createFont and I thought maybe we could just change that case, but Type 1 fonts are getting very rare. Neither Mac nor Windows ship them and Mac at least does not support them at all, and current Linuxes seem to be almost all TTF and OTF fonts. Also T1 fonts are small, so any minimal peformance benefit is not worth it. There isn't a specific regression test.
I verified this on Ubuntu 20.04 which has at least a (very) few Type 1 fonts.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/258/head:pull/258
$ git checkout pull/258