Skip to content

Conversation

@Ravi-Patel8
Copy link
Contributor

@Ravi-Patel8 Ravi-Patel8 commented Jun 16, 2025

Bug Ref: https://bugs.openjdk.org/browse/JDK-8361484

The following keys are removed:

filename.-monotype-timesnewromanwt-medium-r-normal---%d-75-75--*-gb2312.1980-0=/usr/lpp/X11/lib/X11/fonts/TrueType/tnrwt_s.ttf

filename.-monotype-wt_serif_sc-medium-r-normal---%d-75-75--*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/TrueType/wt__s__b.ttf

Signed-off-by: Ravi.Patel8 Ravi.Patel8@ibm.com


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361484: Remove duplicate font filename mappings in fontconfig.properties for AIX (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25823/head:pull/25823
$ git checkout pull/25823

Update a local copy of the PR:
$ git checkout pull/25823
$ git pull https://git.openjdk.org/jdk.git pull/25823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25823

View PR using the GUI difftool:
$ git pr show -t 25823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25823.diff

Using Webrev

Link to Webrev Comment

…nfig.properties

The following keys are removed:

filename.-monotype-timesnewromanwt-medium-r-normal---%d-75-75--*-gb2312.1980-0=/usr/lpp/X11/lib/X11/fonts/TrueType/tnrwt_s.ttf

filename.-monotype-wt_serif_sc-medium-r-normal---%d-75-75--*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/TrueType/wt__s__b.ttf
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

👋 Welcome back Ravi-Patel8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@Ravi-Patel8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361484: Remove duplicate font filename mappings in fontconfig.properties for AIX

Reviewed-by: serb, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 240 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@Ravi-Patel8 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 16, 2025
Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you need the bugID to resolve the jcheck warnings.

@Ravi-Patel8
Copy link
Contributor Author

Note that you need the bugID to resolve the jcheck warnings.

Thank you @mrserb, We’ve reported the bug, and it is available at: https://bugs.openjdk.org/browse/JDK-8361484

@Ravi-Patel8 Ravi-Patel8 changed the title Duplicate keys removed in src/java.desktop/aix/data/fontconfig/fontconfig.properties 8361484: Duplicate keys removed in src/java.desktop/aix/data/fontconfig/fontconfig.properties Jul 7, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025
@Ravi-Patel8 Ravi-Patel8 requested a review from mrserb July 7, 2025 10:26
@Ravi-Patel8 Ravi-Patel8 changed the title 8361484: Duplicate keys removed in src/java.desktop/aix/data/fontconfig/fontconfig.properties 8361484: Remove duplicate font filename mappings in fontconfig.properties for AIX Jul 7, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025

Webrevs

@Ravi-Patel8
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@Ravi-Patel8
Your change (at version b3da410) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Jul 9, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

Going to push as commit 19bb6eb.
Since your change was applied there have been 259 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2025
@openjdk openjdk bot closed this Jul 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@mrserb @Ravi-Patel8 Pushed as commit 19bb6eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants