Skip to content

Conversation

@suchismith1993
Copy link
Contributor

@suchismith1993 suchismith1993 commented Jun 16, 2025

JBS Issue : JDK-8349077

we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349077: Rename GenerationCounters::update_all (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25831/head:pull/25831
$ git checkout pull/25831

Update a local copy of the PR:
$ git checkout pull/25831
$ git pull https://git.openjdk.org/jdk.git pull/25831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25831

View PR using the GUI difftool:
$ git pr show -t 25831

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25831.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@suchismith1993 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jun 16, 2025
@suchismith1993 suchismith1993 marked this pull request as ready for review June 16, 2025 13:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant