8359423: Improve error message in case of missing jsa shared archive by MBaesken · Pull Request #25846 · openjdk/jdk

MBaesken · 2025-06-17T08:17:19Z

In case we use -Xshare:on with additional flags (regarding coh or coops) and we have the corresponding jsa archive not present,
we get this message/error :

Error occurred during initialization of VM
Unable to use shared archive.

The error message could be a little improved, e.g. telling what jsa file is not present .
For example

./images/jdk/bin/java -Xshare:on -version
[0.017s][error][aot] Opening of static archive /build_linux/images/jdk/lib/server/classes.jsa failed
Error occurred during initialization of VM
Unable to use shared archive (unrecoverable archive loading error).

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8359423: Improve error message in case of missing jsa shared archive (Enhancement - P4)

Reviewers

Martin Doerr (@TheRealMDoerr - Reviewer)
Andreas Steiner (@ansteiner - Author)
Evgeny Astigeevich (@eastig - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25846/head:pull/25846
$ git checkout pull/25846

Update a local copy of the PR:
$ git checkout pull/25846
$ git pull https://git.openjdk.org/jdk.git pull/25846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25846

View PR using the GUI difftool:
$ git pr show -t 25846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25846.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-17T08:18:01Z

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-17T08:18:19Z

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359423: Improve error message in case of missing jsa shared archive

Reviewed-by: mdoerr, asteiner, eastigeevich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

02d7281: 8367483: C2 crash in PhaseValues::type: assert(t != nullptr) failed: must set before get - missing notification for CastX2P(SubL(x, y))
15dd96f: 8144124: [macosx] The tabs can't be aligned when we pressing the key of 'R','B','L','C' or 'T'.
d13769d: 8367501: RISC-V: build broken after JDK-8365926
... and 34 more: https://git.openjdk.org/jdk/compare/c968a672c034fe533ea5f4ac5efe37ffb76c93e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-06-17T08:19:06Z

@MBaesken The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-17T08:21:38Z

Webrevs

eastig · 2025-06-17T15:47:08Z

src/hotspot/share/cds/metaspaceShared.cpp

  }
  if (RequireSharedSpaces && has_failed) {
-      MetaspaceShared::unrecoverable_loading_error("Unable to map shared spaces");
+      MetaspaceShared::unrecoverable_loading_error("Unable to map shared spaces, but they were required");


If you want the message to be more specific, you might need to add whether the failed loading was dynamic or static.

src/hotspot/share/cds/metaspaceShared.cpp

bridgekeeper · 2025-07-15T21:51:58Z

@MBaesken This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

MBaesken · 2025-07-16T07:19:35Z

/touch

openjdk · 2025-07-16T07:20:05Z

@MBaesken The pull request is being re-evaluated and the inactivity timeout has been reset.

bridgekeeper · 2025-08-13T10:47:55Z

@MBaesken This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

MBaesken · 2025-08-13T11:08:47Z

/touch

openjdk · 2025-08-13T11:11:03Z

@MBaesken The pull request is being re-evaluated and the inactivity timeout has been reset.

…cds tests

MBaesken · 2025-09-11T12:16:00Z

I added the message passed to AOTMetaspace::unrecoverable_loading_error(const char* message) to the vm_exit output and also slightly adjusted the output so that it still fits to the runtime/cds/appcds tests .

src/hotspot/share/cds/aotMetaspace.cpp

TheRealMDoerr · 2025-09-11T15:44:41Z

Otherwise, LGTM.

TheRealMDoerr

Thanks!

ansteiner

LGTM

eastig

lgtm

MBaesken · 2025-09-13T20:19:23Z

Thanks for the reviews !

/integrate

openjdk · 2025-09-13T20:20:12Z

Going to push as commit ef291d2.
Since your change was applied there have been 48 commits pushed to the master branch:

ff538c7: 8367583: sun/security/util/AlgorithmConstraints/InvalidCryptoDisabledAlgos.java fails after JDK-8244336
e2eaa2e: 8357708: com.sun.jndi.ldap.Connection ignores queued LDAP replies if Connection is subsequently closed
3eb3e0d: 8366833: Poly1305 does not always correctly update position for array-backed ByteBuffers after processMultipleBlocks
... and 45 more: https://git.openjdk.org/jdk/compare/c968a672c034fe533ea5f4ac5efe37ffb76c93e2...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-09-13T20:20:20Z

@MBaesken Pushed as commit ef291d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8359423

df28ad4

openjdk bot changed the title ~~JDK-8359423: Improve error message in case of missing jsa shared archive~~ 8359423: Improve error message in case of missing jsa shared archive Jun 17, 2025

openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 17, 2025

eastig reviewed Jun 17, 2025

View reviewed changes

src/hotspot/share/cds/metaspaceShared.cpp Outdated Show resolved Hide resolved

MBaesken added 5 commits August 15, 2025 14:15

Adjust log message in metaspaceShared

991e4d9

Merge remote-tracking branch 'origin/master' into JDK-8359423

8858819

merge aotMetaspace.cpp

4290115

Adjust message in aotMetaspace and make it fit to the runtime/cds/app…

11b92d1

…cds tests

Fix message

5784207

TheRealMDoerr reviewed Sep 11, 2025

View reviewed changes

src/hotspot/share/cds/aotMetaspace.cpp Outdated Show resolved Hide resolved

Add hint suggested by mdoerr

0f098f2

TheRealMDoerr approved these changes Sep 12, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2025

ansteiner approved these changes Sep 12, 2025

View reviewed changes

eastig approved these changes Sep 12, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 13, 2025

openjdk bot closed this Sep 13, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2025

Conversation

MBaesken commented Jun 17, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 17, 2025

Uh oh!

openjdk bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 17, 2025

Uh oh!

mlbridge bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

eastig Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bridgekeeper bot commented Jul 15, 2025

Uh oh!

MBaesken commented Jul 16, 2025

Uh oh!

openjdk bot commented Jul 16, 2025

Uh oh!

bridgekeeper bot commented Aug 13, 2025

Uh oh!

MBaesken commented Aug 13, 2025

Uh oh!

openjdk bot commented Aug 13, 2025

Uh oh!

MBaesken commented Sep 11, 2025

Uh oh!

Uh oh!

TheRealMDoerr commented Sep 11, 2025

Uh oh!

TheRealMDoerr left a comment

Choose a reason for hiding this comment

Uh oh!

ansteiner left a comment

Choose a reason for hiding this comment

Uh oh!

eastig left a comment

Choose a reason for hiding this comment

Uh oh!

MBaesken commented Sep 13, 2025

Uh oh!

openjdk bot commented Sep 13, 2025

Uh oh!

openjdk bot commented Sep 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

MBaesken commented Jun 17, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 17, 2025 •

edited

Loading

mlbridge bot commented Jun 17, 2025 •

edited

Loading