-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8359923: Const accessors for the Deferred class #25874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into |
|
@jsikstro This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
jdksjolen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and trivial
|
Thank you for the quick review @jdksjolen! |
|
I've asked that this change be backed out. I don't think this change should |
The name Deferred was chosen when we thought that we would be allowed to use this utility to defer initialization for more situations than just static objects. If we are going to lock this down to only use it for static objects, then I think we also should rename the utility accordingly. |
Hello,
This RFE adds const accessors to the
Deferredclass. We plan on using this in a future patch in ZGC. Thanks!Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25874/head:pull/25874$ git checkout pull/25874Update a local copy of the PR:
$ git checkout pull/25874$ git pull https://git.openjdk.org/jdk.git pull/25874/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25874View PR using the GUI difftool:
$ git pr show -t 25874Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25874.diff
Using Webrev
Link to Webrev Comment