Skip to content

Conversation

@jsikstro
Copy link
Member

@jsikstro jsikstro commented Jun 18, 2025

Hello,

This RFE adds const accessors to the Deferred class. We plan on using this in a future patch in ZGC. Thanks!

Testing:

  • Currently running tier1-2
  • Works in an WIP ZGC patch

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359923: Const accessors for the Deferred class (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25874/head:pull/25874
$ git checkout pull/25874

Update a local copy of the PR:
$ git checkout pull/25874
$ git pull https://git.openjdk.org/jdk.git pull/25874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25874

View PR using the GUI difftool:
$ git pr show -t 25874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25874.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359923: Const accessors for the Deferred class

Reviewed-by: jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

Copy link
Contributor

@jdksjolen jdksjolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and trivial

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2025
@jsikstro
Copy link
Member Author

Thank you for the quick review @jdksjolen!
/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

Going to push as commit 42d3604.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cf78925: 8358891: Remove the PerfDataSamplingIntervalFunc code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 18, 2025
@openjdk openjdk bot closed this Jun 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@jsikstro Pushed as commit 42d3604.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett
Copy link

I've asked that this change be backed out. I don't think this change should
have been made. I've proposed a better solution for the use-case that led to
making this change.

@stefank
Copy link
Member

stefank commented Jun 23, 2025

I've asked that this change be backed out. I don't think this change should
have been made. I've proposed a better solution for the use-case that led to
making this change.

The name Deferred was chosen when we thought that we would be allowed to use this utility to defer initialization for more situations than just static objects. If we are going to lock this down to only use it for static objects, then I think we also should rename the utility accordingly.

@jsikstro jsikstro deleted the JDK-8359923_const_deferred branch June 27, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants