Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException #2588

Closed
wants to merge 1 commit into from

Conversation

@simon04
Copy link
Contributor

@simon04 simon04 commented Feb 16, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2588/head:pull/2588
$ git checkout pull/2588

Update a local copy of the PR:
$ git checkout pull/2588
$ git pull https://git.openjdk.java.net/jdk pull/2588/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2588

View PR using the GUI difftool:
$ git pr show -t 2588

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2588.diff

@bridgekeeper bridgekeeper bot added the oca label Feb 16, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 16, 2021

Hi @simon04, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user simon04" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@simon04 The following labels will be automatically applied to this pull request:

  • core-libs
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Copy link
Contributor

@shipilev shipilev left a comment

This looks good to me. Are you willing to continue with this PR? I see that OCA is still pending. I have created the bug for this issue: https://bugs.openjdk.java.net/browse/JDK-8264031 -- please change PR synopsis to "8264031: Fix typo in ZipFileSystem.deleteFile ZipException" to get it hooked appropriately.

@simon04 simon04 changed the title ZipFileSystem: fix typo in ZipException 8264031: Fix typo in ZipFileSystem.deleteFile ZipException Mar 23, 2021
@simon04
Copy link
Contributor Author

@simon04 simon04 commented Mar 23, 2021

/signed

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 23, 2021

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 24, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine to me.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 25, 2021

Note that the PR synopsis should now match the bug title, as bot says in "Integration Blocker". I think "(zipfs)" is missing.

@simon04 simon04 changed the title 8264031: Fix typo in ZipFileSystem.deleteFile ZipException 8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException Mar 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 27, 2021

@simon04 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264031: (zipfs) Typo in ZipFileSystem.deleteFile ZipException

Reviewed-by: shade, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 985 new commits pushed to the master branch:

  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters
  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • ... and 975 more: https://git.openjdk.java.net/jdk/compare/8ba390d1e243c5ec2e637263fa44907b664e8ceb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 27, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 24, 2021

@simon04 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@simon04
Copy link
Contributor Author

@simon04 simon04 commented Apr 25, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2021

@simon04
Your change (at version 16ec3b9) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 26, 2021

/sponsor

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot removed the rfr label Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@shipilev @simon04 Since your change was applied there have been 987 commits pushed to the master branch:

  • 56fbef0: 8265681: G1: general cleanup for G1FullGCHeapRegionAttr
  • 578a0b3: 8261238: NMT should not limit baselining by size threshold
  • 3bf4c90: 8264317: Lanai: IncorrectUnmanagedImageRotatedClip.java fails on apple M1
  • f1f2afd: 8264028: Typo in javax.management.relation.RelationService::purgeRelations
  • f6e22d1: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64
  • 0257ac1: 8252089: Remove psParallelCompact internal debug counters
  • 4b7f027: 8231179: Investigate why tools/javac/options/BCPOrSystemNotSpecified.java fails on Window
  • d87a4c3: 8239596: PARAMETER annotation on receiver type does not cause error
  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • ... and 977 more: https://git.openjdk.java.net/jdk/compare/8ba390d1e243c5ec2e637263fa44907b664e8ceb...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7b609a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants