Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260416: Remove unused method ReferenceProcessor::is_mt_processing_set_up() #2591

Closed
wants to merge 1 commit into from

Conversation

@lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Feb 16, 2021

Code is not used.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260416: Remove unused method ReferenceProcessor::is_mt_processing_set_up()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2591/head:pull/2591
$ git checkout pull/2591

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 16, 2021

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Feb 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 16, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260416: Remove unused method ReferenceProcessor::is_mt_processing_set_up()

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • fc1d032: 8261125: Move VM_Operation to vmOperation.hpp
  • d547e1a: 8261123: Augment discussion of equivalence classes in Object.equals and comparison methods
  • 2677f6f: 8261675: ObjectValue::set_visited(bool) sets _visited false
  • e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
  • 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
  • 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 17, 2021
@lkorinth
Copy link
Contributor Author

@lkorinth lkorinth commented Feb 18, 2021

Thanks Albert and Kim!

Loading

@lkorinth
Copy link
Contributor Author

@lkorinth lkorinth commented Feb 18, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@lkorinth Since your change was applied there have been 27 commits pushed to the master branch:

  • 3a21e1d: 8260653: Unreachable nodes keep speculative types alive
  • b695c7e: 8261925: ProblemList com/sun/jdi/AfterThreadDeathTest.java on Linux
  • 97e1657: 8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream
  • b8fd614: 8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp
  • 5f30829: 8202750: Reduce the use of get_canonical_path() in CDS
  • ea5bf45: 8261621: Delegate Unicode history from JLS to j.l.Character
  • d5a4d22: 8261843: incorrect info in docs/building.html
  • bf75a3a: 8261851: update ReflectionCallerCacheTest.java test to use ForceGC from test library
  • 05301f5: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
  • cb84539: 8261553: Efficient mask generation using BMI2 BZHI instruction
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/61a659f4bfe066250af871b9d84943bed526e71d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1a7adc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@lkorinth lkorinth deleted the _8260416 branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants