-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360169: Problem list CodeInvalidationReasonTest.java on linux-riscv64 until JDK-8360168 is fixed #25924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…4 until JDK-8360168 is fixed
|
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
|
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @feilongjiang, @sendaoYan, @dougxc) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@DingliZhang To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label add hotspot-compiler |
|
/label add graal |
|
@DingliZhang |
|
@DingliZhang |
|
GHA report configure fails 'Could not find a C compiler' on windows-x64 and windows-aarch64, I think it's unrelated to this PR. |
|
Thanks all for the review! |
|
@DingliZhang |
|
/sponsor |
|
Going to push as commit ad1033d.
Your commit was automatically rebased without conflicts. |
|
@feilongjiang @DingliZhang Pushed as commit ad1033d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
As described in the JDK-8360168 issue, the case failed on linux-riscv64. We put the failed test
case into the Problem list until JDK-8360168 is fixed.
Please take a look and have some reviews. Thanks a lot.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25924/head:pull/25924$ git checkout pull/25924Update a local copy of the PR:
$ git checkout pull/25924$ git pull https://git.openjdk.org/jdk.git pull/25924/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25924View PR using the GUI difftool:
$ git pr show -t 25924Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25924.diff
Using Webrev
Link to Webrev Comment