Skip to content

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jun 21, 2025

Hi all,
As described in the JDK-8360168 issue, the case failed on linux-riscv64. We put the failed test
case into the Problem list until JDK-8360168 is fixed.

Please take a look and have some reviews. Thanks a lot.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360169: Problem list CodeInvalidationReasonTest.java on linux-riscv64 until JDK-8360168 is fixed (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25924/head:pull/25924
$ git checkout pull/25924

Update a local copy of the PR:
$ git checkout pull/25924
$ git pull https://git.openjdk.org/jdk.git pull/25924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25924

View PR using the GUI difftool:
$ git pr show -t 25924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25924.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2025

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2025

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360169: Problem list CodeInvalidationReasonTest.java on linux-riscv64 until JDK-8360168 is fixed

Reviewed-by: fyang, fjiang, syan, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @feilongjiang, @sendaoYan, @dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2025
@openjdk
Copy link

openjdk bot commented Jun 21, 2025

@DingliZhang To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@DingliZhang
Copy link
Member Author

/label add hotspot-compiler

@DingliZhang
Copy link
Member Author

/label add graal

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 22, 2025
@openjdk
Copy link

openjdk bot commented Jun 22, 2025

@DingliZhang
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the graal graal-dev@openjdk.org label Jun 22, 2025
@openjdk
Copy link

openjdk bot commented Jun 22, 2025

@DingliZhang
The graal label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 22, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2025
@sendaoYan
Copy link
Member

GHA report configure fails 'Could not find a C compiler' on windows-x64 and windows-aarch64, I think it's unrelated to this PR.

@DingliZhang
Copy link
Member Author

Thanks all for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@DingliZhang
Your change (at version f2d474b) is now ready to be sponsored by a Committer.

@feilongjiang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

Going to push as commit ad1033d.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2025
@openjdk openjdk bot closed this Jun 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@feilongjiang @DingliZhang Pushed as commit ad1033d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants