8358641: C1 option -XX:+TimeEachLinearScan is broken

[sarannat]

Issue
Using the command java -Xcomp -XX:TieredStopAtLevel=1 -XX:+TimeEachLinearScan results in an assert failure in line assert(_cached_blocks.length() == ir()->linear_scan_order()->length()) failed: invalid cached block list.

Suggestion
Removal of flag as this is a very old issue

Fix
Removed the flag by removing relevant methods and code while ensuring the removal does not affect other flags.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358641: C1 option -XX:+TimeEachLinearScan is broken (Bug - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25933/head:pull/25933
$ git checkout pull/25933

Update a local copy of the PR:
$ git checkout pull/25933
$ git pull https://git.openjdk.org/jdk.git pull/25933/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25933

View PR using the GUI difftool:
$ git pr show -t 25933

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25933.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back snatarajan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sarannat This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358641: C1 option -XX:+TimeEachLinearScan is broken

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 9f7dc19: 8353276: C2: simplify PhaseMacroExpand::opt_bits_test
• 805f1de: 8342941: IGV: Add various new graph dumps during loop opts
• b85440d: 8361888: [GCC static analyzer] ProcessImpl_md.c Java_java_lang_ProcessImpl_forkAndExec error: use of uninitialized value '*(ChildStuff *)p.mode
• ... and 34 more: https://git.openjdk.org/jdk/compare/25e509b0db4f35b3b8fbfeb7ec84cc0e0fed89d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@sarannat The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d66a4ce9)
• 00: Full (980f9a50)

[chhagedorn]

That looks reasonable, thanks for cleaning it up!

[chhagedorn]

Might have been added by a previous iteration. I suggest to remove it.

Suggested change

[TobiHartmann]

Looks good to me.

[sarannat]

Thank you for the reviews. Please sponsor.

[sarannat]

/integrate

[chhagedorn]

/sponsor

[openjdk]

@sarannat
Your change (at version d66a4ce) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit 6b4a5ef.
Since your change was applied there have been 37 commits pushed to the master branch:

• 9f7dc19: 8353276: C2: simplify PhaseMacroExpand::opt_bits_test
• 805f1de: 8342941: IGV: Add various new graph dumps during loop opts
• b85440d: 8361888: [GCC static analyzer] ProcessImpl_md.c Java_java_lang_ProcessImpl_forkAndExec error: use of uninitialized value '*(ChildStuff *)p.mode
• ... and 34 more: https://git.openjdk.org/jdk/compare/25e509b0db4f35b3b8fbfeb7ec84cc0e0fed89d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn @sarannat Pushed as commit 6b4a5ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.