Skip to content

Conversation

@ascarpino
Copy link
Contributor

@ascarpino ascarpino commented Jun 23, 2025

Hi

This is a clean backport to jdk25 for updates to the PEM spec.

PEMRecord.pem is renamed to content to better describe that it is the base64 content and not including the header and footer. Additionally, PEMRecord.getEncoded() is removed and some javadoc clarifications for PEMEncoder and PEMDecoder.
Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8358100 to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25940/head:pull/25940
$ git checkout pull/25940

Update a local copy of the PR:
$ git checkout pull/25940
$ git pull https://git.openjdk.org/jdk.git pull/25940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25940

View PR using the GUI difftool:
$ git pr show -t 25940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25940.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2025

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358099: PEM spec updates

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 78158f30aee51e14ab203b0127aeb883c010319c 8358099: PEM spec updates Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@ascarpino The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 23, 2025
@ascarpino ascarpino marked this pull request as ready for review June 23, 2025 17:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2025
@ascarpino
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

Going to push as commit b89f364.
Since your change was applied there have been 5 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2025
@openjdk openjdk bot closed this Jun 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@ascarpino Pushed as commit b89f364.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants