Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 24, 2025

Add back has_mfdscr() checks which were recently removed. See #20262 (comment)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360405: [PPC64] some environments don't support mfdscr instruction (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25953/head:pull/25953
$ git checkout pull/25953

Update a local copy of the PR:
$ git checkout pull/25953
$ git pull https://git.openjdk.org/jdk.git pull/25953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25953

View PR using the GUI difftool:
$ git pr show -t 25953

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25953.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360405: [PPC64] some environments don't support mfdscr instruction

Reviewed-by: haosun, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2025

Webrevs

Copy link
Contributor

@shqking shqking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix. It works in my local test environment(QEMU) now.

@TheRealMDoerr
Copy link
Contributor Author

Thanks for testing and for the review!

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
Cheers, Richard.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 25, 2025
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review! GHA and our internal tests have passed. We'll also need a JDK25 backport.
/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2025

Going to push as commit f71d64f.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2025
@openjdk openjdk bot closed this Jun 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2025
@openjdk
Copy link

openjdk bot commented Jun 25, 2025

@TheRealMDoerr Pushed as commit f71d64f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8360405_PPC64_mfdscr branch June 25, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants