8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block

[ravigupta30]

Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left debris on system whenever fails its required frame.dispose() in finally block.

 finally {
            EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
        }
    public static void disposeFrame() {
        if (frame != null) {
            frame.dispose();
            frame = null;
        }
    }

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block (Bug - P4)

Reviewers

• Abhishek Kumar (@kumarabhi006 - Reviewer)
• Phil Race (@prrace - Reviewer) Review applies to 995c93b1
• Damon Nguyen (@DamonGuy - Committer)
• Manukumar V S (@manukumarvs - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26043/head:pull/26043
$ git checkout pull/26043

Update a local copy of the PR:
$ git checkout pull/26043
$ git pull https://git.openjdk.org/jdk.git pull/26043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26043

View PR using the GUI difftool:
$ git pr show -t 26043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26043.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgupta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ravigupta30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block

Reviewed-by: abhiscxk, dnguyen, mvs, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6042 new commits pushed to the master branch:

• 57434c7: 8365976: G1: Full gc should mark nmethods on stack
• 28bd29f: 8365034: G1: Remove num_groups_selected in G1CollectionSet::select_candidates_from_optional_groups as it is unnecessary
• 7fa501e: 8365040: G1: Remove sorting at end of collection set selection
• ... and 6039 more: https://git.openjdk.org/jdk/compare/75220da26f647c6f3dabc05cea81cefaf3a1e195...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kumarabhi006, @prrace, @DamonGuy, @manukumarvs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@ravigupta30 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 08: Full - Incremental (83a8bc7e)
• 07: Full - Incremental (fd70f19f)
• 06: Full - Incremental (af4d38e1)
• 05: Full - Incremental (995c93b1)
• 04: Full - Incremental (a45a9bf7)
• 03: Full - Incremental (ecaa0334)
• 02: Full - Incremental (417d94e1)
• 01: Full - Incremental (1a2cb6e0)
• 00: Full (db5a1913)

[ravigupta30]

any volunteer for review?

[kumarabhi006]

Fix to dispose the frame looks good but the test needs re-factoring like expand wild imports, accessing UI components on EDT, code formatting etc.

I suggest to raise a JBS issue to address these issues.

[kumarabhi006]

Copyright year needs to update.
Space formatting is required throughout the code. e.g. L58, L62 etc...
Add @overide for the overridden methods.
SOP statement inside mouseDragged contains commented code... can be removed.
SOP inside mousePressed and mouseReleased can be consistent with other APIs, Pressed instead of >>>.
Commented code can be removed.
Object initialization and setting up the mouse listener can be moved to constructor. I don't think extending Frame is required.

[ravigupta30]

@kumarabhi006 i have refactor the test its solved yours suggestions.
Please have a look.

[kumarabhi006]

Looks good to me now. Just a minor correction can be done in summary.

[kumarabhi006]

LGTM

[ravigupta30]

@prrace requesting you to please re-review the changes

[DamonGuy]

Tested on macOS and Ubuntu 24.04 (Wayland & X). Test passes on all except I get a timeout error on Wayland. Can you confirm that this test passes on your end on Wayland?

[ravigupta30]

@DamonGuy I have tested it on Ubuntu 20.4 wayland its runs fine.

jpgansible@blrsqe011:~/ravi$ uname -a
Linux blrsqe011.in.oracle.com 6.14.0-15-generic #15-Ubuntu SMP PREEMPT_DYNAMIC Sun Apr  6 15:05:05 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
jpgansible@blrsqe011:~/ravi$ loginctl show-session $(awk '/tty/ {print $1}' <(loginctl)) -p Type | awk -F= '{print $2}'
wayland
jpgansible@blrsqe011:~/ravi$ jdk-26/bin/java -version
java version "26-ea" 2026-03-17
Java(TM) SE Runtime Environment (build 26-ea+9-927)
Java HotSpot(TM) 64-Bit Server VM (build 26-ea+9-927, mixed mode, sharing)
jpgansible@blrsqe011:~/ravi$ jdk-26/bin/java ExtraButtonDrag.java 
areExtraMouseButtonsEnabled() == true
button to drag = 1 : value passed to robot = 1024
button to drag = 2 : value passed to robot = 2048
button to drag = 3 : value passed to robot = 4096
Test Passed
jpgansible@blrsqe011:~/ravi$

[DamonGuy]

Re-tested and works fine as explained. Issue was on my end and was resolved.

[ravigupta30]

/integrate

[openjdk]

@ravigupta30
Your change (at version 83a8bc7) is now ready to be sponsored by a Committer.

[manukumarvs]

/sponsor

[openjdk]

Going to push as commit 21efd25.
Since your change was applied there have been 6049 commits pushed to the master branch:

• a629424: 8365579: ml64.exe is not the right assembler for Windows aarch64
• 1a7ac16: 8364382: Remove sun/tools/jstat/jstatLineCountsX.sh from ProblemList on linux-ppc64le and aix due to JDK-8248691
• 63faa50: 8365291: Remove finalize() method from sun/awt/X11InputMethodBase.java
• ... and 6046 more: https://git.openjdk.org/jdk/compare/75220da26f647c6f3dabc05cea81cefaf3a1e195...master

Your commit was automatically rebased without conflicts.

[openjdk]

@manukumarvs @ravigupta30 Pushed as commit 21efd25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.