Skip to content

8261843: incorrect info in docs/building.html #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

magicus
Copy link
Member

@magicus magicus commented Feb 17, 2021

The file doc/building.html says to use make print-configure to show the command line used for your current configuration. It should be make print-configuration


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2605/head:pull/2605
$ git checkout pull/2605

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Feb 17, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261843: incorrect info in docs/building.html

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 149 new commits pushed to the master branch:

  • 9ba2b71: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal
  • f639df4: 8261401: Add sanity check for UseSHM large pages similar to the one used with hugetlb large pages
  • 2e18b52: 8261752: Multiple GC test are missing memory requirements
  • c7885eb: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 05d5955: 8261522: [PPC64] AES intrinsics write beyond the destination array
  • 03b586b: 8261750: Remove internal class sun.net.www.MimeLauncher
  • 8418285: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check
  • a930870: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
  • b955f85: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
  • d195033: 8261842: Shenandoah: cleanup ShenandoahHeapRegionSet
  • ... and 139 more: https://git.openjdk.java.net/jdk/compare/43ae0cf878548ba56b88459290145a776839bcf5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 17, 2021
@magicus
Copy link
Member Author

magicus commented Feb 17, 2021

/integrate

@openjdk openjdk bot closed this Feb 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@magicus Since your change was applied there have been 153 commits pushed to the master branch:

  • bf75a3a: 8261851: update ReflectionCallerCacheTest.java test to use ForceGC from test library
  • 05301f5: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
  • cb84539: 8261553: Efficient mask generation using BMI2 BZHI instruction
  • a065879: 8261791: (sctp) handleSendFailed in SctpChannelImpl.c potential leaks
  • 9ba2b71: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal
  • f639df4: 8261401: Add sanity check for UseSHM large pages similar to the one used with hugetlb large pages
  • 2e18b52: 8261752: Multiple GC test are missing memory requirements
  • c7885eb: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 05d5955: 8261522: [PPC64] AES intrinsics write beyond the destination array
  • 03b586b: 8261750: Remove internal class sun.net.www.MimeLauncher
  • ... and 143 more: https://git.openjdk.java.net/jdk/compare/43ae0cf878548ba56b88459290145a776839bcf5...master

Your commit was automatically rebased without conflicts.

Pushed as commit d5a4d22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the fix-docs-for-make-print-configuration branch October 7, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants