8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

[jaikiran]

Can I please get a review of this test-only change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8359337?

On macOS, the JDK by default (without any explicit system properties) picks up the proxy settings configured on the host. These proxy settings then get used by the JVM wide DefaultProxySelector. That can then result in some tests, like the ones listed in that issue, to fail.

The commit in this PR updates these tests to disable the proxy when running these tests. I've verified that after these changes, these tests now pass on the host where these tests were failing previously. Additionally I've run tier2 to make sure nothing else is impacted due to this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected (Bug - P4)

Reviewers

• Joe Wang (@JoeWang-Java - Reviewer) Review applies to 8389ac03
• Lance Andersen (@LanceAndersen - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26052/head:pull/26052
$ git checkout pull/26052

Update a local copy of the PR:
$ git checkout pull/26052
$ git pull https://git.openjdk.org/jdk.git pull/26052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26052

View PR using the GUI difftool:
$ git pr show -t 26052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26052.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

Reviewed-by: lancea, iris, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• aa19111: 8360867: CTW: Disable inline cache verification
• 00adbbe: 8274051: Remove supports_vtime()/elapsedVTime()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (17c4febb)
• 00: Full (8389ac03)

[JoeWang-Java]

Thanks Jaikiran. nit: may add the bug id (8359337) to the @bug tag.

[LanceAndersen]

Thank you for the assist with this Jai

[jaikiran]

Thank you Joe and Lance for the reviews. I've updated the tests to include the bug id as suggested by Joe. I'll integrate this tomorrow.

[jdlib]

What is the error seen on macOS when the proxy is not disabled?

[jaikiran]

Hello Johannes,

What is the error seen on macOS when the proxy is not disabled?

These tests have been written to trigger specific error conditions. Some of them rely on a specific exception being thrown when communicating with an address that is known to be invalid. When a proxy is involved, the communication with the target address happens over the proxy which results in a different error (which depends on the proxy implementation). That causes the assertions in these tests to fail.

[jaikiran]

Thank you all for the reviews. I'll go ahead and integrate this now.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 7583a7b.
Since your change was applied there have been 14 commits pushed to the master branch:

• e85c7d0: 8360790: G1: Improve HRRSStatsIter name
• eec1153: 8361056: Parallel: Use correct is_par argument in ScavengeRootsTask
• fc739fe: 8360206: Refactor ReferenceProcessor::balance_queues
• ... and 11 more: https://git.openjdk.org/jdk/compare/c2d76f9844aadf77a0b213a9169a7c5c8c8f1ffb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 7583a7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jaikiran]

/backport :jdk25

[openjdk]

@jaikiran the backport was successfully created on the branch backport-jaikiran-7583a7b8-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7583a7b8 from the openjdk/jdk repository.

The commit being backported was authored by Jaikiran Pai on 1 Jul 2025 and was reviewed by Lance Andersen, Iris Clark and Joe Wang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-jaikiran-7583a7b8-jdk25:backport-jaikiran-7583a7b8-jdk25
$ git checkout backport-jaikiran-7583a7b8-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-jaikiran-7583a7b8-jdk25