8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix)

[TheRealMDoerr]

Follow-up for #26021. See latest comments there.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix) (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Joachim Kern (@JoKern65 - Committer)

Contributors

• Alan Bateman <alanb@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26066/head:pull/26066
$ git checkout pull/26066

Update a local copy of the PR:
$ git checkout pull/26066
$ git pull https://git.openjdk.org/jdk.git pull/26066/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26066

View PR using the GUI difftool:
$ git pr show -t 26066

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26066.diff

Using Webrev

Link to Webrev Comment

[TheRealMDoerr]

/contributor add alanb

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix)

Co-authored-by: Alan Bateman <alanb@openjdk.org>
Reviewed-by: alanb, jkern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• ce99869: 8359120: Improve warning message when fail to load hsdis library
• eac8f5d: 8325478: Restructure the macro expansion compiler phase to not include macro elimination
• 2304044: 8360641: TestCompilerCounts fails after 8354727
• ... and 17 more: https://git.openjdk.org/jdk/compare/e85c7d09df67728ddcf852a96e5b2baa57c502f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TheRealMDoerr
Contributor Alan Bateman <alanb@openjdk.org> successfully added.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[TheRealMDoerr]

@AlanBateman: Thanks for your thorough review of the original change! And sorry that I was too quick. There are currently too many issues...
I have followed your suggestions and added you as contributor.

[mlbridge]

Webrevs

• 01: Full - Incremental (f1659ca3)
• 00: Full (222cea0b)

[AlanBateman]

Can you try this:

if (type == UserDefinedFileAttributeView.class) { 
    UnixPath file = UnixPath.toUnixPath(obj);
    return supportsUserDefinedFileAttributeView(file) ? ..

That will remove the cast/check from supportsUserDefinedFileAttributeView and also ensure that ProviderMismatchException is thrown if called with a Path from a different provider.

[TheRealMDoerr]

I like this version much better. Changed.

[TheRealMDoerr]

Thanks for the review and your guidance!

[JoKern65]

LGTM

[TheRealMDoerr]

Thanks! I've verified that the test still catches the bug when I remove the fix. It's a bit more cumbersome to read, but ok:

java.lang.RuntimeException: Assertion failed
        at Basic.assertTrue(Basic.java:57)
        at Basic.testFileAttributes(Basic.java:77)
        at Basic.doTests(Basic.java:114)
        at Basic.main(Basic.java:49)

The fix still works and tier1-4 have passed. Let's ship it!
/integrate

[openjdk]

Going to push as commit c460f84.
Since your change was applied there have been 23 commits pushed to the master branch:

• 549b875: 8361112: Use exact float -> Float16 conversion method in Float16 tests
• 832bfbc: 8338474: Parallel: Deprecate and obsolete PSChunkLargeArrays
• 3066a67: 8361101: AOTCodeAddressTable::_stubs_addr not initialized/freed properly
• ... and 20 more: https://git.openjdk.org/jdk/compare/e85c7d09df67728ddcf852a96e5b2baa57c502f1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit c460f84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.