Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jul 1, 2025

Backporting under granted JDK 25 enhancement request.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359436: AOTCompileEagerly should not be diagnostic (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26073/head:pull/26073
$ git checkout pull/26073

Update a local copy of the PR:
$ git checkout pull/26073
$ git pull https://git.openjdk.org/jdk.git pull/26073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26073

View PR using the GUI difftool:
$ git pr show -t 26073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26073.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359436: AOTCompileEagerly should not be diagnostic

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e138297323de3f6990c4c536b1cefd209ce3a69c 8359436: AOTCompileEagerly should not be diagnostic Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 1, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 1, 2025
@shipilev
Copy link
Member Author

shipilev commented Jul 2, 2025

Thanks! Here goes.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

Going to push as commit b245c51.
Since your change was applied there have been 2 commits pushed to the jdk25 branch:

  • 0a151c6: 8358179: Performance regression in Math.cbrt
  • 554e38d: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2025
@openjdk openjdk bot closed this Jul 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@shipilev Pushed as commit b245c51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants