Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261905: Move implementation of OopStorage num_dead related functions #2608

Closed
wants to merge 2 commits into from

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Feb 17, 2021

Please review this trivial change which just moves several functions to a
different location in the same file. The old location is in the middle of
some unrelated functionality.

Testing:
mach5 tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261905: Move implementation of OopStorage num_dead related functions

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2608/head:pull/2608
$ git checkout pull/2608

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Feb 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Feb 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261905: Move implementation of OopStorage num_dead related functions

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 17, 2021
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Feb 19, 2021

Thanks @albertnetymk and @tschatzl for reviews.

/integrate

Loading

@openjdk openjdk bot closed this Feb 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@kimbarrett Pushed as commit 7e78c77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kimbarrett kimbarrett deleted the move_num_dead branch Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants