Skip to content

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 2, 2025

Hi all,

This pull request contains a backport of commit 38f59f84 from the openjdk/jdk repository.

The commit being backported was authored by Mohamed Issa on 1 Jul 2025 and was reviewed by Sandhya Viswanathan, Srinivas Vamsi Parasa and Emanuel Peter.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358179: Performance regression in Math.cbrt (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26085/head:pull/26085
$ git checkout pull/26085

Update a local copy of the PR:
$ git checkout pull/26085
$ git pull https://git.openjdk.org/jdk.git pull/26085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26085

View PR using the GUI difftool:
$ git pr show -t 26085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26085.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2025

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358179: Performance regression in Math.cbrt

Reviewed-by: epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 38f59f84c98dfd974eec0c05541b2138b149def7 8358179: Performance regression in Math.cbrt Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2025

Webrevs

Copy link
Contributor

@eme64 eme64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 2, 2025
@TobiHartmann
Copy link
Member Author

Thanks for the review Emanuel!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

Going to push as commit 0a151c6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2025
@openjdk openjdk bot closed this Jul 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@TobiHartmann Pushed as commit 0a151c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants