-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8358179: Performance regression in Math.cbrt #26085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8358179: Performance regression in Math.cbrt #26085
Conversation
|
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
|
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
@TobiHartmann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
eme64
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the review Emanuel! |
|
/integrate |
|
Going to push as commit 0a151c6. |
|
@TobiHartmann Pushed as commit 0a151c6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 38f59f84 from the openjdk/jdk repository.
The commit being backported was authored by Mohamed Issa on 1 Jul 2025 and was reviewed by Sandhya Viswanathan, Srinivas Vamsi Parasa and Emanuel Peter.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26085/head:pull/26085$ git checkout pull/26085Update a local copy of the PR:
$ git checkout pull/26085$ git pull https://git.openjdk.org/jdk.git pull/26085/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26085View PR using the GUI difftool:
$ git pr show -t 26085Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26085.diff
Using Webrev
Link to Webrev Comment