8261666: [mlvm] Remove WhiteBoxHelper

[lepestock]

The mlvm test suite used this class for situations when WhiteBox was not available during the test's build time - therefore, the test tried to find the WhiteBox on runtime.

These days, the WhiteBox is always available so this is not the case. The said helper is to be removed and its only user adjusted.

Testing: test/hotspot/jtreg/vmTestBase/vm/mlvm on linux/mac/windows x64.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261666: [mlvm] Remove WhiteBoxHelper

Reviewers

• Igor Ignatyev (@iignatev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2609/head:pull/2609
$ git checkout pull/2609

[bridgekeeper]

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lepestock The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a8ded93)

[iignatev]

👍

[openjdk]

@lepestock This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261666: [mlvm] Remove WhiteBoxHelper

Reviewed-by: iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 428 new commits pushed to the master branch:

• e33bfb3: 8263450: Simplify LambdaForm.useCount
• 75ef6f5: 8263427: Shenandoah: Trigger weak-LRB even when heap is stable
• 4517d72: 8263612: Unused variables in C1 runtime
• 83a9a02: 8263509: LdapSchemaParser.readNextTag checks array length incorrectly
• 9c50b8e: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
• 68deb24: 8080272: Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy
• a31a23d: 8263595: Remove oop type punning in JavaCallArguments
• a1f6591: 8263589: Introduce JavaValue::get_oop/set_oop
• 20297a1: 8263577: C2: reachable nodes shouldn't have dead uses at the end of optimizations
• c484d89: 8263557: Possible NULL dereference in Arena::destruct_contents()
• ... and 418 more: https://git.openjdk.java.net/jdk/compare/8b6ab31d313de61a0ef39722bc8e5fe0e10a8279...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iignatev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lepestock]

/integrate

[openjdk]

@lepestock
Your change (at version a8ded93) is now ready to be sponsored by a Committer.

[iignatev]

/sponsor

[openjdk]

@iignatev @lepestock Since your change was applied there have been 437 commits pushed to the master branch:

• 5069796: 8263164: assert(_base >= VectorA && _base <= VectorZ) failed: Not a Vector while calling StoreVectorNode::memory_size()
• 996079b: 8260650: test failed with "assert(false) failed: infinite loop in PhaseIterGVN::optimize"
• 9cb9af6: 8260959: remove RECORDS from PreviewFeature.Feature enum
• 05fe06a: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
• 422eba8: 8263536: Add @build tags to jpackage tests
• 0d2f87e: 8263562: Checking if proxy_klass_head is still lambda_proxy_is_available
• a67a679: 8263679: C1: Remove vtable call
• 11c8c78: 8248904: Add support to jpackage for the Mac App Store
• dc93138: 8256732: Zero: broken +ZeroTLAB exposes badly initialized memory
• e33bfb3: 8263450: Simplify LambdaForm.useCount
• ... and 427 more: https://git.openjdk.java.net/jdk/compare/8b6ab31d313de61a0ef39722bc8e5fe0e10a8279...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4acb883.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.