-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix) #26097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix) #26097
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Thanks! I'm glad to have this fixed in jdk25. Our tests are green. |
|
Going to push as commit 8a98738.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit 8a98738. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8361183.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26097/head:pull/26097$ git checkout pull/26097Update a local copy of the PR:
$ git checkout pull/26097$ git pull https://git.openjdk.org/jdk.git pull/26097/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26097View PR using the GUI difftool:
$ git pr show -t 26097Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26097.diff
Using Webrev
Link to Webrev Comment