Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 2, 2025

Clean backport of JDK-8361183.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26097/head:pull/26097
$ git checkout pull/26097

Update a local copy of the PR:
$ git checkout pull/26097
$ git pull https://git.openjdk.org/jdk.git pull/26097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26097

View PR using the GUI difftool:
$ git pr show -t 26097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26097.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix)

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jdk25 branch:

  • ab01396: 8361101: AOTCodeAddressTable::_stubs_addr not initialized/freed properly
  • 92268e1: 8359870: JVM crashes in AccessInternal::PostRuntimeDispatch

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk25 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c460f842bf768995b271cd6362940877a4a79665 8361183: JDK-8360887 needs fixes to avoid cycles and better tests (aix) Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 3, 2025
@TheRealMDoerr
Copy link
Contributor Author

Thanks! I'm glad to have this fixed in jdk25. Our tests are green.
/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2025

Going to push as commit 8a98738.
Since your change was applied there have been 2 commits pushed to the jdk25 branch:

  • ab01396: 8361101: AOTCodeAddressTable::_stubs_addr not initialized/freed properly
  • 92268e1: 8359870: JVM crashes in AccessInternal::PostRuntimeDispatch

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2025
@openjdk openjdk bot closed this Jul 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2025
@openjdk
Copy link

openjdk bot commented Jul 3, 2025

@TheRealMDoerr Pushed as commit 8a98738.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants