8358768: [vectorapi] Make VectorOperators.SUADD an Associative

[igraves]

Adding SUADD an associative operation in the Vector API. Saturated addition on fixed-width unsigned integers is provably associative.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358768: [vectorapi] Make VectorOperators.SUADD an Associative (Enhancement - P4)

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26099/head:pull/26099
$ git checkout pull/26099

Update a local copy of the PR:
$ git checkout pull/26099
$ git pull https://git.openjdk.org/jdk.git pull/26099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26099

View PR using the GUI difftool:
$ git pr show -t 26099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26099.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358768: [vectorapi] Make VectorOperators.SUADD an Associative

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 199 new commits pushed to the master branch:

• 5cf672e: 8359053: Implement JEP 504 - Remove the Applet API
• a10ee46: 8361224: [macos] MacSignTest.testMultipleCertificates failed
• 6cff49c: 8361380: ARM32: Atomic stubs should be in pre-universe
• ... and 196 more: https://git.openjdk.org/jdk/compare/20e0055e202e523b40e8b066e2f71c21d8cc5ea9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[igraves]

/label core-libs

[openjdk]

@igraves
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 03: Full - Incremental (c88f20ef)
• 02: Full - Incremental (8cfc55ee)
• 01: Full - Incremental (6c8d8952)
• 00: Full (0abdd644)

[igraves]

/integrate

[openjdk]

Going to push as commit b65fdf5.
Since your change was applied there have been 211 commits pushed to the master branch:

• d2082c5: 8358621: Reduce busy waiting in worse case at the synchronization point returning from native in CPU Time Profiler
• 563e876: 8358540: Enhance MathUtils in view of FloatingDecimal enhancements
• c70258c: 8358619: Fix interval recomputation in CPU Time Profiler
• ... and 208 more: https://git.openjdk.org/jdk/compare/20e0055e202e523b40e8b066e2f71c21d8cc5ea9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@igraves Pushed as commit b65fdf5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[merykitty]

I believe this is inadequate, an Associative will allow reduction operation. You need to add support for SUADD to that, too.

[PaulSandoz]

I believe this is inadequate, an Associative will allow reduction operation. You need to add support for SUADD to that, too.

Grrr... yes thank you for spotting that obvious omission. We can do that in a follow on PR, but without any intrinsic implementation in the reductionOperations switch.

[igraves]

Will create a bug. Thanks @merykitty !