8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification

[bplb]

Modify CharBuffer.getChars to respect the class level specification that the provided buffer offset srcBegin is relative to the buffer's current position.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8361308 to be approved

Issues

• JDK-8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification (Bug - P2)
• JDK-8361308: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification (CSR)

Reviewers

• Chen Liang (@liach - Reviewer) Review applies to e9abd20f
• Alan Bateman (@AlanBateman - Reviewer)

Reviewers without OpenJDK IDs

• @bokken (no known openjdk.org user name / role) Review applies to e9abd20f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26104/head:pull/26104
$ git checkout pull/26104

Update a local copy of the PR:
$ git checkout pull/26104
$ git pull https://git.openjdk.org/jdk.git pull/26104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26104

View PR using the GUI difftool:
$ git pr show -t 26104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26104.diff

Using Webrev

Link to Webrev Comment

[bplb]

/csr

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification

Reviewed-by: alanb, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 25ed36f: 8359493: Refactor how aggregated mandatory warnings are handled in the compiler
• a2315dd: 8357739: [jittester] disable the hashCode method
• 66836d4: 8361292: Rename ModuleEntry::module() to module_oop()
• ... and 11 more: https://git.openjdk.org/jdk/compare/ea86a20e6d74baea54df32415d9096d3b7bba1d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-8361299 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a98e8dd4)
• 01: Full - Incremental (e9abd20f)
• 00: Full (5bbc34d4)

[bplb]

jdk_core tests passed on Linux in the CI.

[mlbridge]

Mailing list message from Brian Burkhalter on nio-dev:

On Jul 2, 2025, at 2:49?PM, Brett Okken <duke at openjdk.org> wrote:

Marked as reviewed by bokken at github.com<mailto:bokken at github.com> (no known OpenJDK username).

Thanks for the review.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/nio-dev/attachments/20250702/fb756742/attachment-0001.htm>

[bplb]

/integrate

[openjdk]

Going to push as commit 6249259.
Since your change was applied there have been 85 commits pushed to the master branch:

• a41d350: 8357473: Compilation spike leaves many CompileTasks in free list
• 7daf981: 8346884: Add since checker test to jdk.editpad
• a201be8: 8361255: CTW: Tolerate more NCDFE problems
• ... and 82 more: https://git.openjdk.org/jdk/compare/ea86a20e6d74baea54df32415d9096d3b7bba1d7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 6249259.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[bplb]

/backport :jdk25

[openjdk]

@bplb the backport was successfully created on the branch backport-bplb-6249259c-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6249259c from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 9 Jul 2025 and was reviewed by Alan Bateman and Chen Liang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-bplb-6249259c-jdk25:backport-bplb-6249259c-jdk25
$ git checkout backport-bplb-6249259c-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-bplb-6249259c-jdk25