8361355: Negative cases of Annotated.getAnnotationData implementations are broken

[dougxc]

This PR fixes bugs in the implementation of jdk.vm.ci.meta.Annotated.getAnnotationData:

1. Calling getAnnotatedData(annotationType) fails with an ArrayIndexOutOfBoundsException instead of returning null when the receiver type is not annotated by annotationType.
2. Calling either of the getAnnotatedData methods with an annotationType value that does not represent an annotation interface silently succeeds when the receiver type does not (or can not) have any annotations (e.g. array and primitive types).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361355: Negative cases of Annotated.getAnnotationData implementations are broken (Bug - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26116/head:pull/26116
$ git checkout pull/26116

Update a local copy of the PR:
$ git checkout pull/26116
$ git pull https://git.openjdk.org/jdk.git pull/26116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26116

View PR using the GUI difftool:
$ git pr show -t 26116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26116.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361355: Negative cases of Annotated.getAnnotationData implementations are broken

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• a2315dd: 8357739: [jittester] disable the hashCode method
• 66836d4: 8361292: Rename ModuleEntry::module() to module_oop()
• 3daa03c: 8358680: AOT cache creation fails: no strings should have been added
• ... and 82 more: https://git.openjdk.org/jdk/compare/1ca008fd02496dc33e2707c102560cae1690fba5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ec161d59)
• 01: Full - Incremental (b25684f7)
• 00: Full (86b41636)

[openjdk]

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[tkrodriguez]

Looks good.

[dougxc]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 5cf349c.
Since your change was applied there have been 95 commits pushed to the master branch:

• 21f2e9a: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner
• 854de8c: 8336147: Clarify CDS documentation about static vs dynamic archive
• 16af473: 8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException
• ... and 92 more: https://git.openjdk.org/jdk/compare/1ca008fd02496dc33e2707c102560cae1690fba5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 5cf349c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.