8261649: AArch64: Optimize LSE atomics in C++ code #2612
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have support for LSE atomics in C++ HotSpot source, we can generate much better code for them. In particular, the sequence we generate for CMPXCHG with a full two-way barrier using two DMBs is way suboptimal.
Barrier-ordered-before, Arm Architecture Reference Manual B2.3 :
| Barrier instructions order prior Memory effects before subsequent
| Memory effects generated by the same Observer. A read or a write RW1
| is Barrier-ordered-before a read or a write RW2 from the same Observer
| if and only if RW1 appears in program order before RW2 and any of the
| following cases apply:
|
| [...]
|
| * RW1 appears in program order before an atomic instruction with both
| Acquire and Release semantics that appears in program order before RW2.
So a prior load or store cannot be reordered with the load of an atomic swap with Acquire and Release semantics. This barrier-ordered-before in combination with sequential consistency gives us everything we need for a full barrier. However, we still need a DMB after the cmpxchg to ensure that subsequent loads and stores cannot be reordered with the store in an atomic instruction.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2612/head:pull/2612
$ git checkout pull/2612