Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8261350: Create implementation for NSAccessibilityCheckBox protocol peer #2613

Closed
wants to merge 1 commit into from
Closed

8261350: Create implementation for NSAccessibilityCheckBox protocol peer #2613

wants to merge 1 commit into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Feb 17, 2021 •
edited by openjdk bot
Loading

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261350: Create implementation for NSAccessibilityCheckBox protocol peer

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2613/head:pull/2613
$ git checkout pull/2613

@azuev-java
8261350: Create implementation for NSAccessibilityCheckBox protocol peer
16827cb 
Initial implementation
Further import simplification
Fixed wrong commentarry in the RadiobuttonAccessibility implementation
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added awt client-libs-dev@openjdk.org rfr Pull request is ready for review labels Feb 17, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 19, 2021 •
edited
Loading

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261350: Create implementation for NSAccessibilityCheckBox protocol peer

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • a180a38: 8260694: (fc) Clarify FileChannel.transferFrom to better describe "no bytes available" case
  • 1b0c36b: 8261649: AArch64: Optimize LSE atomics in C++ code
  • 61820b7: 8259984: IGV: Crash when drawing control flow before GCM
  • 7e2c909: 8260485: Simplify and unify handler vectors in Posix signal code
  • c99eeb0: 8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer
  • 5caf686: 8261644: NMT: Simplifications and cleanups
  • ed93bc9: 8196301: java/awt/print/PrinterJob/Margins.java times out
  • 7e78c77: 8261905: Move implementation of OopStorage num_dead related functions
  • 78cde64: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • c158413: 8261098: Add clhsdb "findsym" command
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/34ae7aeb64db90dcb4d2f3d4acb16c714a32824f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 19, 2021
@azuev-java
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2021
@openjdk
Copy link

openjdk bot commented Feb 20, 2021

@azuev-java Since your change was applied there have been 67 commits pushed to the master branch:

  • 5a25cea: 8261998: Remove unused shared entry support from utilities/hashtable
  • 4755958: 8262041: javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java fails after JDK-8260858
  • b10376b: 8261938: ASN1Formatter.annotate should not return in the finally block
  • 977a21a: 8261225: TieredStopAtLevel should have no effect if TieredCompilation is disabled
  • c53acc2: 8261542: X86 slice and unslice intrinsics for 256-bit byte/short vectors
  • 8b4fd77: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows
  • 7ffa148: 8247918: Clarify Reader.skip behavior for end of stream
  • 8a1c712: 8261728: SimpleDateFormat should link to DateTimeFormatter
  • 851b2e3: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance
  • c4f17a3: 8257925: enable more support for nested inline tags
  • ... and 57 more: https://git.openjdk.java.net/jdk/compare/34ae7aeb64db90dcb4d2f3d4acb16c714a32824f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2b00367.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@azuev-java azuev-java deleted the JDK-8261350 branch February 21, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankaj-bansal pankaj-bansal pankaj-bansal approved these changes

Assignees
No one assigned
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
2 participants
@azuev-java @pankaj-bansal